Customer anonymisation if reviews coming from version 3 #92

jf-viguier · 2020-12-17T17:42:08Z

Questions	Answers
Description?	If registered customer : return customer name instead of using customer_name of comment. By the way, it's better not to return full name for gdpr concern.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#22481
How to test?	it's described on the issue

This fix is included, it's needed to make it works https://github.com/PrestaShop/productcomments/pull/89/files
I've also fixed a typo on isLastNameAnynomus

jf-viguier · 2020-12-17T17:47:23Z

CS fixer returned "PHP needs to be a minimum version of PHP 5.6.0 and maximum version of PHP 7.4.*."
Can a maintainer fix this ?

SimonGrn

Thank you @jf-viguier !
I fixed a small misspell in Anonymous.

controllers/front/ListComments.php

jf-viguier · 2020-12-18T13:36:41Z

Thank you @jf-viguier !
I fixed a small misspell in Anonymous.

Thanks

PierreRambaud · 2020-12-21T09:46:03Z

I rebase your pull request for CS fixer :)

jf-viguier · 2020-12-21T10:07:06Z

thanks @PierreRambaud, checks ok now. Ready for review.

atomiix · 2021-01-04T09:42:33Z

Hi @jf-viguier, could you resolve the conflicting file please?

jf-viguier · 2021-01-04T11:51:15Z

@atomiix, resolved

atomiix · 2021-01-04T17:46:36Z

@jf-viguier I think you can remove your last commit, it doesn't seem to contain any change 🤔

jf-viguier · 2021-01-05T09:30:04Z

@atomiix, I don't understand, it was a conflit resolution on a variable.

…tead of using customer_name

Co-authored-by: Simon G. <49909275+SimonGrn@users.noreply.github.com>

atomiix · 2021-01-05T10:30:57Z

@jf-viguier I don't know what happened either 😅 but I just rebased it and it looks ok now!

sarahdib · 2021-02-05T10:48:48Z

@jf-viguier
I didn't reproduce the issue but there is another issue
Step to reproduce :

Install prestashop 1.6.1.24
Install module product comment 3.6.0
Add a comment
Upgrade prestashop
Upgrade the porduct comment module to the last version
Go to FO

After adding a comment

The bug appear with and without this pr

jf-viguier · 2021-02-05T11:13:07Z

@sarahdib is your comment validated ? Is it in database ?

sarahdib · 2021-02-08T08:21:07Z

@jf-viguier Yes the comment is validated and in database.

Progi1984 · 2021-05-06T07:24:21Z

@sarahdib Have you created an issue ?

jf-viguier · 2021-06-04T14:08:54Z

@sarahdib with my pr here #107
You will be able to test all of this

jf-viguier · 2021-06-09T12:47:26Z

@sarahdib can you test now with this pr and #107 ?

sarahdib · 2021-07-22T10:50:27Z

@matks this pr should not be in waiting for QA. We can test it if #107 is not approved and merged.

jf-viguier · 2021-10-22T12:45:13Z

any news here ?

Progi1984 · 2021-10-25T07:50:13Z

@sarahdib is waiting for the #107 (WFAuthor). Could you contact @khouloudbelguith on Slack for discussing about this PR (and bug related) ?

hibatallahAouadni · 2022-01-17T15:30:37Z

As this PR #107 has been approved, I remove the Blocked label.
But we have to wait for the PR #107 to be merged so that we can add the waiting for QA label.

Progi1984 · 2022-01-17T20:56:09Z

@hibatallahAouadni It's merged.

hibatallahAouadni · 2022-01-20T13:57:18Z

Hello @jf-viguier

Thanks for your hard working 👏
For the comments by logged-in customers, their last names are anonymized ✔️
For the comments by guests, their last names are not anonymized ✔️

pr_92.mp4

PS: sorry about check the second option as not correct in the screen record 😅

Well then, LGTM and QA ✔️
Thanks!

PierreRambaud · 2022-01-20T14:03:41Z

Thank you @jf-viguier

SimonGrn reviewed Dec 17, 2020

View reviewed changes

controllers/front/ListComments.php Outdated Show resolved Hide resolved

controllers/front/ListComments.php Outdated Show resolved Hide resolved

jf-viguier mentioned this pull request Dec 18, 2020

Customer Review Anonymisation PrestaShop/PrestaShop#16339

Closed

PierreRambaud force-pushed the anonymisation-issue-oldmodule branch from 1a65079 to 574e80d Compare December 21, 2020 09:45

PierreRambaud closed this Dec 21, 2020

PierreRambaud reopened this Dec 21, 2020

PierreRambaud approved these changes Dec 21, 2020

View reviewed changes

PierreRambaud added the waiting for QA label Dec 21, 2020

PierreRambaud added this to the 4.2.2 milestone Dec 21, 2020

atomiix added the waiting for author label Jan 4, 2021

jf-viguier and others added 3 commits January 5, 2021 11:23

if registered customer : return customer first name and last name ins…

48875b7

…tead of using customer_name

Update controllers/front/ListComments.php

6bccc7c

Co-authored-by: Simon G. <49909275+SimonGrn@users.noreply.github.com>

Update controllers/front/ListComments.php

6567b96

Co-authored-by: Simon G. <49909275+SimonGrn@users.noreply.github.com>

atomiix force-pushed the anonymisation-issue-oldmodule branch from beddfc7 to 6567b96 Compare January 5, 2021 10:27

atomiix approved these changes Jan 5, 2021

View reviewed changes

PierreRambaud approved these changes Jan 5, 2021

View reviewed changes

PierreRambaud removed the waiting for author label Jan 5, 2021

sarahdib added the waiting for author label Feb 5, 2021

PierreRambaud removed the waiting for author label Feb 5, 2021

sarahdib removed waiting for QA waiting for author labels Apr 1, 2021

Progi1984 approved these changes Apr 7, 2021

View reviewed changes

sowbiba approved these changes Apr 7, 2021

View reviewed changes

matthieu-rolland approved these changes Apr 22, 2021

View reviewed changes

PierreRambaud approved these changes Apr 22, 2021

View reviewed changes

Progi1984 added the waiting for QA label Apr 22, 2021

sarahdib added Locked by another PR Blocked and removed waiting for QA Locked by another PR labels Apr 23, 2021

jf-viguier mentioned this pull request Jun 4, 2021

Fix upgrade module to v4 #107

Merged

matks added the waiting for QA label Jul 22, 2021

sarahdib removed the waiting for QA label Jul 22, 2021

hibatallahAouadni removed the Blocked label Jan 17, 2022

Progi1984 added the waiting for QA label Jan 17, 2022

hibatallahAouadni self-assigned this Jan 18, 2022

hibatallahAouadni added QA ✔️ and removed waiting for QA labels Jan 20, 2022

PierreRambaud merged commit 23904e5 into PrestaShop:dev Jan 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Customer anonymisation if reviews coming from version 3 #92

Customer anonymisation if reviews coming from version 3 #92

jf-viguier commented Dec 17, 2020 •

edited by hibatallahAouadni

Loading

jf-viguier commented Dec 17, 2020 •

edited

Loading

SimonGrn left a comment

jf-viguier commented Dec 18, 2020

PierreRambaud commented Dec 21, 2020

jf-viguier commented Dec 21, 2020

atomiix commented Jan 4, 2021

jf-viguier commented Jan 4, 2021

atomiix commented Jan 4, 2021

jf-viguier commented Jan 5, 2021

atomiix commented Jan 5, 2021

sarahdib commented Feb 5, 2021 •

edited

Loading

jf-viguier commented Feb 5, 2021

sarahdib commented Feb 8, 2021

Progi1984 commented May 6, 2021

jf-viguier commented Jun 4, 2021

jf-viguier commented Jun 9, 2021

sarahdib commented Jul 22, 2021

jf-viguier commented Oct 22, 2021

Progi1984 commented Oct 25, 2021

hibatallahAouadni commented Jan 17, 2022 •

edited

Loading

Progi1984 commented Jan 17, 2022

hibatallahAouadni commented Jan 20, 2022

PierreRambaud commented Jan 20, 2022

Customer anonymisation if reviews coming from version 3 #92

Customer anonymisation if reviews coming from version 3 #92

Conversation

jf-viguier commented Dec 17, 2020 • edited by hibatallahAouadni Loading

jf-viguier commented Dec 17, 2020 • edited Loading

SimonGrn left a comment

Choose a reason for hiding this comment

jf-viguier commented Dec 18, 2020

PierreRambaud commented Dec 21, 2020

jf-viguier commented Dec 21, 2020

atomiix commented Jan 4, 2021

jf-viguier commented Jan 4, 2021

atomiix commented Jan 4, 2021

jf-viguier commented Jan 5, 2021

atomiix commented Jan 5, 2021

sarahdib commented Feb 5, 2021 • edited Loading

jf-viguier commented Feb 5, 2021

sarahdib commented Feb 8, 2021

Progi1984 commented May 6, 2021

jf-viguier commented Jun 4, 2021

jf-viguier commented Jun 9, 2021

sarahdib commented Jul 22, 2021

jf-viguier commented Oct 22, 2021

Progi1984 commented Oct 25, 2021

hibatallahAouadni commented Jan 17, 2022 • edited Loading

Progi1984 commented Jan 17, 2022

hibatallahAouadni commented Jan 20, 2022

PierreRambaud commented Jan 20, 2022

jf-viguier commented Dec 17, 2020 •

edited by hibatallahAouadni

Loading

jf-viguier commented Dec 17, 2020 •

edited

Loading

sarahdib commented Feb 5, 2021 •

edited

Loading

hibatallahAouadni commented Jan 17, 2022 •

edited

Loading