Fix translations on customer account page

[micka-fdz]

Questions	Answers
Description?	This PR fixes customer account page translations
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#27942.
How to test?	See issue

[matthieu-rolland]

Thank you for your PR @micka-fdz 👍

can you explain how and why you generated these keys ?

[micka-fdz]

Hi @matthieu-rolland.

Old version of this module (v1.1.0) have template files for both PS versions:

• customerPersonalData16.tpl (translation key: customerpersonaldata16)
• customerPersonalData17.tpl (translation key: customerpersonaldata17)

Today we just have one template file customerPersonalData.tpl (translation key: customerpersonaldata).

In my PR, I just removed translations with customerpersonaldata16 key and rename customerpersonaldata17 key to customerpersonaldata.

[matthieu-rolland]

Thank you for your information

I'm not sure about renaming customerpersonaldata17 into customerpersonaldata, what if we add a new file for the next major (prestashop 8.0 ?)

@PrestaShop/prestashop-core-developers what do you guys think ? I'm not so familiar with this module

[micka-fdz]

@matthieu-rolland module translation system works like that: translation key is equal to file name.

My PR just fixed translations for current template file. It's a common issue on this module.
If we add new file in the future, translation files will have to be regenerated.

[matthieu-rolland]

thanx @micka-fdz, sorry for the misunderstanding 👍

[florine2623]

Hello @micka-fdz ,

Thanks for the PR !

Looking good to me.
Tested with multiple different languages, translation is always correct.

This is QA ✅

[Progi1984]

Thanks @micka-fdz & @florine2623