Skip to content

Commit

Permalink
WEBREF-49 📦 Resolved react-side-effect dependency (#1297)
Browse files Browse the repository at this point in the history
This dep was previously resolving to a version which was actively using a deprecated lifecycle method and causing noise in the build/test log.

The makers of the react-helmet library (which uses the dep), are working on a new release to overcome this: nfl/react-helmet#413 (comment).

We'll pick this up with dependabot once it's out of beta.

Co-authored-by: Sonya Moisset <sonya.moisset@gmail.com>
  • Loading branch information
egmcdonald and SonyaMoisset committed Jan 28, 2020
1 parent 0196458 commit b4ed299
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,5 +126,8 @@
"ts-loader": "^6.2.1",
"typescript": "^3.7.2",
"typescript-styled-plugin": "^0.15.0"
},
"resolutions": {
"react-side-effect": "^2.1.0"
}
}
12 changes: 5 additions & 7 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -15515,12 +15515,10 @@ react-select@^3.0.0:
react-input-autosize "^2.2.2"
react-transition-group "^2.2.1"

react-side-effect@^1.1.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/react-side-effect/-/react-side-effect-1.2.0.tgz#0e940c78faba0c73b9b0eba9cd3dda8dfb7e7dae"
integrity sha512-v1ht1aHg5k/thv56DRcjw+WtojuuDHFUgGfc+bFHOWsF4ZK6C2V57DO0Or0GPsg6+LSTE0M6Ry/gfzhzSwbc5w==
dependencies:
shallowequal "^1.0.1"
react-side-effect@^1.1.0, react-side-effect@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/react-side-effect/-/react-side-effect-2.1.0.tgz#1ce4a8b4445168c487ed24dab886421f74d380d3"
integrity sha512-IgmcegOSi5SNX+2Snh1vqmF0Vg/CbkycU9XZbOHJlZ6kMzTmi3yc254oB1WCkgA7OQtIAoLmcSFuHTc/tlcqXg==

react-sizeme@^2.5.2, react-sizeme@^2.6.7:
version "2.6.12"
Expand Down Expand Up @@ -16899,7 +16897,7 @@ shallow-equal@^1.1.0:
resolved "https://registry.yarnpkg.com/shallow-equal/-/shallow-equal-1.2.1.tgz#4c16abfa56043aa20d050324efa68940b0da79da"
integrity sha512-S4vJDjHHMBaiZuT9NPb616CSmLf618jawtv3sufLl6ivK8WocjAo58cXwbRV1cgqxH0Qbv+iUt6m05eqEa2IRA==

shallowequal@^1.0.1, shallowequal@^1.1.0:
shallowequal@^1.1.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/shallowequal/-/shallowequal-1.1.0.tgz#188d521de95b9087404fd4dcb68b13df0ae4e7f8"
integrity sha512-y0m1JoUZSlPAjXVtPPW70aZWfIL/dSP7AFkRnniLCrK/8MDKog3TySTBmckD+RObVxH0v4Tox67+F14PdED2oQ==
Expand Down

0 comments on commit b4ed299

Please sign in to comment.