Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solarized Light Theme for PrismJS #855

Merged
merged 4 commits into from
Jan 27, 2016

Conversation

hectormatos2011
Copy link
Contributor

I quite like the solarized themes - they are pretty accessible and a lot of work was done on created something that is easy on the eyes. I ported Solarized Light for PrismJS. It would be pretty cool if the solarized themes were included with PrismJS! However, after some research, I couldn't quite see any attribution rules so I provided a link to the original creator of the solarized formats in a comment at the top of the css file.

I quite like the solarized themes - they are pretty accessible and a lot of work was done on created something that is easy on the eyes. I ported Solarized Light for PrismJS. It would be pretty cool if the solarized themes were included with PrismJS! However, after some research, I couldn't quite see any attribution rules so I provided a link to the original creator of the solarized formats in a comment at the top of the css file.
This is what happens when an iOS Dev tries his hand at CSS.
…ightcss

New Theme for PrismJS - Solarized Light
@zeitgeist87
Copy link
Collaborator

Hi @hectormatos2011,

Thank you for your contribution. Your theme looks quite nice. You seem to have forgotten to add the file extension .css to the prism-solarizedlight file. You also have to add the theme to the themes section in the /components.js file:

"prism-solarizedlight": {
    "title": "Solarized Light",
    "owner": "hectormatos2011 "
}

I like the subtle nice colors of the theme.

@mAAdhaTTah
Copy link
Member

Prism does have a themes repo: https://github.com/PrismJS/prism-themes Dunno if this theme should be there or here.

@zeitgeist87
Copy link
Collaborator

Prism does have a themes repo: https://github.com/PrismJS/prism-themes Dunno if this theme should be there or here.

@mAAdhaTTah yes that is a good point. I think it should be in prism-themes repo.

@LeaVerou
Copy link
Member

Actually, Solarized is such a popular theme that I think it should be here, and on the website (theme sidebar). Thank you so much @hectormatos2011, I've been wanting this theme for Prism for ages!!

zeitgeist87 added a commit that referenced this pull request Jan 27, 2016
Solarized Light Theme for PrismJS
@zeitgeist87 zeitgeist87 merged commit 661fa26 into PrismJS:gh-pages Jan 27, 2016
@LeaVerou
Copy link
Member

I use Solarized Light on my editor, and this is not Solarized Light. All the colors are darker. Compare:

image
image

Top image is the official screenshot from http://ethanschoonover.com/solarized , bottom image is from Prism’s website. Do they look the same to any of you?

I would be very grateful to whoever can fix this disparity.

@zeitgeist87
Copy link
Collaborator

Top image is the official screenshot from http://ethanschoonover.com/solarized , bottom image is from Prism’s website. Do they look the same to any of you?

I would be very grateful to whoever can fix this disparity.

Sorry for the mess. I'll fix it tomorrow.

@LeaVerou
Copy link
Member

Sorry for the mess. I'll fix it tomorrow.

You're the last person that should be sorry!! Thank you so much for your hard work.

@zeitgeist87
Copy link
Collaborator

My fix is in PR #872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants