Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solarized Light theme #872

Merged
merged 1 commit into from
Jan 28, 2016
Merged

Conversation

zeitgeist87
Copy link
Collaborator

The official color palette is included as a CSS comment and every
color used is named with a comment.

The official color palette is included as a CSS comment and every
color used is named with a comment.
@zeitgeist87
Copy link
Collaborator Author

It definitely needs a bit of tweaking. I am not very good at themes, so I'm open for suggestions on how to improve it.

@zeitgeist87
Copy link
Collaborator Author

The result looks like this:

solarized

LeaVerou added a commit that referenced this pull request Jan 28, 2016
@LeaVerou LeaVerou merged commit bcdd272 into PrismJS:gh-pages Jan 28, 2016
@LeaVerou
Copy link
Member

Thanks!

The main problem I see is that the default color is too light. We should use the darkest color there.

@LeaVerou
Copy link
Member

For anyone interested in helping, here is a comparison. First image is Solarized Light in my editor, second is Prism from the website.

image
image

Ours looks a bit more colorless, but overall, not too bad actually!!
Thanks again @zeitgeist87!!

@mAAdhaTTah
Copy link
Member

That may be a function of the syntax highlighting rather than the theme. You'll notice in the editor tokens.content is two different colors, whereas they're both the same in Prism. Also, in the editor, tokens.map (e.g. {object}.{method}) is highlighted differently than tokens.replace. Not sure more can be done without changing Prism itself.

Also, wondering if a new version of Prism could be pubbed to npm. Would love to get this theme into my plugin ☺.

@zeitgeist87
Copy link
Collaborator Author

Not sure more can be done without changing Prism itself.

We can quite easily make the punctuation red. But I agree, that some of it is not possible with Prism.

Also, wondering if a new version of Prism could be pubbed to npm. Would love to get this theme into my plugin ☺.

@mAAdhaTTah I will try to create a new release this weekend. There is a bit of work involved, because the CHANGELOG has to updated.


pre[class*="language-"]::selection, pre[class*="language-"] ::selection,
code[class*="language-"]::selection, code[class*="language-"] ::selection {
background: #073642; /* base02 */
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate it, if someone could check if the selection looks right. I am not sure if base02 is the right color for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants