-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Solarized Light theme #872
Conversation
The official color palette is included as a CSS comment and every color used is named with a comment.
It definitely needs a bit of tweaking. I am not very good at themes, so I'm open for suggestions on how to improve it. |
Thanks! The main problem I see is that the default color is too light. We should use the darkest color there. |
For anyone interested in helping, here is a comparison. First image is Solarized Light in my editor, second is Prism from the website. Ours looks a bit more colorless, but overall, not too bad actually!! |
That may be a function of the syntax highlighting rather than the theme. You'll notice in the editor Also, wondering if a new version of Prism could be pubbed to npm. Would love to get this theme into my plugin ☺. |
We can quite easily make the punctuation red. But I agree, that some of it is not possible with Prism.
@mAAdhaTTah I will try to create a new release this weekend. There is a bit of work involved, because the CHANGELOG has to updated. |
|
||
pre[class*="language-"]::selection, pre[class*="language-"] ::selection, | ||
code[class*="language-"]::selection, code[class*="language-"] ::selection { | ||
background: #073642; /* base02 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate it, if someone could check if the selection looks right. I am not sure if base02
is the right color for that.
The official color palette is included as a CSS comment and every
color used is named with a comment.