Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs for combining file-based and dict-based configs #6387

Closed
wyli opened this issue Apr 18, 2023 · 0 comments · Fixed by #7109
Closed

APIs for combining file-based and dict-based configs #6387

wyli opened this issue Apr 18, 2023 · 0 comments · Fixed by #7109
Labels

Comments

@wyli
Copy link
Contributor

wyli commented Apr 18, 2023

Is your feature request related to a problem? Please describe.

the current API is private

def _update_args(args: str | dict | None = None, ignore_none: bool = True, **kwargs: Any) -> dict:
"""
Update the `args` with the input `kwargs`.
For dict data, recursively update the content based on the keys.

should be made available properly for reading multiple config files and dictionary-based overrides.

@ericspod ericspod added the Bundles Anything related to bundles label Jul 7, 2023
@wyli wyli added this to MONAI v1.3 Oct 10, 2023
@wyli wyli moved this to Bundle Todo in MONAI v1.3 Oct 10, 2023
wyli added a commit that referenced this issue Oct 10, 2023
Fixes #6387
Fixes #5899

### Description
- add api for update_kwargs
- add support of merging multiple configs files and dictionaries
- remove warning message of directory in `runtests.sh`

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@github-project-automation github-project-automation bot moved this from Bundle Todo to Done in MONAI v1.3 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants