Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6387 update_kwargs for merging multiple configs #7109

Merged
merged 9 commits into from
Oct 10, 2023
Merged

6387 update_kwargs for merging multiple configs #7109

merged 9 commits into from
Oct 10, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Oct 10, 2023 •
edited
Loading

Fixes #6387
Fixes #5899

Description

  • add api for update_kwargs
  • add support of merging multiple configs files and dictionaries
  • remove warning message of directory in runtests.sh

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits October 10, 2023 13:33
@wyli
add update_kwargs api
168e520 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove logging
bd92475 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu October 10, 2023 12:49
ericspod
ericspod approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wyli added 4 commits October 10, 2023 14:59
@wyli
update based on comments
b38bdb8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update based on comments; fixes Project-MONAI#5899
f2ba40c 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove error message dir
9747510 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
improve bundle run logging
732cc50 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 10, 2023

/build

@wyli
fixes test
9babee4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 10, 2023

/build

@wyli
fixes mypy issue
9fe05c6 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 10, 2023

/build

@wyli wyli enabled auto-merge (squash) October 10, 2023 19:29
@wyli
backward compatible
6b9f64a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 10, 2023

/build

@wyli wyli merged commit 8d730cd into Project-MONAI:dev Oct 10, 2023
26 checks passed
@wyli wyli deleted the 6387-merge-args branch October 10, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu left review comments

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wyli @ericspod @KumoLiu