Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove matrix api destination/sources length <= coordinates length check #5289

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

ghoshkaj
Copy link
Member

@ghoshkaj ghoshkaj commented Dec 4, 2018

Issue

We have a table size check so there is no need to enforce this limit in the query parameters as well.

This PR removes this additional limit enforcement.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@ghoshkaj ghoshkaj requested a review from danpat December 4, 2018 17:38
@ghoshkaj ghoshkaj force-pushed the matrix-sources-destinations-length-check branch from 04cae02 to 4655fcb Compare December 4, 2018 17:51
@ghoshkaj ghoshkaj force-pushed the matrix-sources-destinations-length-check branch from 4655fcb to f82e9f6 Compare December 4, 2018 18:02
@ghoshkaj ghoshkaj changed the title remove destination/srouces length <= coordinates length check remove destination/sources length <= coordinates length check Dec 4, 2018
@ghoshkaj ghoshkaj changed the title remove destination/sources length <= coordinates length check remove matrix api destination/sources length <= coordinates length check Dec 4, 2018
@ghoshkaj ghoshkaj merged commit 98ea2a0 into master Dec 4, 2018
@ghoshkaj ghoshkaj deleted the matrix-sources-destinations-length-check branch December 4, 2018 18:35
ghoshkaj added a commit that referenced this pull request Dec 10, 2018
* Prepare RC.1

* Bump version.

* remove destination/sources length <= coordinates length check (#5289)

* Add node 10 builds to travis (#5246)

* Add node 10 builds to travis

* Add changelog

* bump version to rc5

* Fix fallback_speed vector access (#5291)

* add failing cuke test

* correctly access durations vector

* changelog

* one more cuke test

* bump rc version

* 5.20.0

* remove line from changelog about commit that isn't actually in here

* update CHANGELOG and osrm version in package.json for v5.20.0

* bump to restart appveyor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants