Fix fallback_speed vector access #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoshkaj
force-pushed
the
fix-fallback_speed
branch
from
1a1bde6 to
d6ac257
Compare
danpaz
approved these changes
Dec 5, 2018
6 tasks
ghoshkaj
added a commit
that referenced
this pull request
Dec 5, 2018
* add failing cuke test * correctly access durations vector * changelog * one more cuke test
ghoshkaj
added a commit
that referenced
this pull request
Dec 10, 2018
* Prepare RC.1 * Bump version. * remove destination/sources length <= coordinates length check (#5289) * Add node 10 builds to travis (#5246) * Add node 10 builds to travis * Add changelog * bump version to rc5 * Fix fallback_speed vector access (#5291) * add failing cuke test * correctly access durations vector * changelog * one more cuke test * bump rc version * 5.20.0 * remove line from changelog about commit that isn't actually in here * update CHANGELOG and osrm version in package.json for v5.20.0 * bump to restart appveyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If there is an assymetric (more sources than destinations) matrix request and fallback_speed is used, garbage is returned, or it segfaults. This PR fixes this issue.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?