Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bundling of url properties (like for @font-face + src) during CSS file optimization #1199

Closed
thescientist13 opened this issue Jan 22, 2024 · 0 comments · Fixed by #1211, #1208 or #1235
Assignees
Labels
alpha.2 CLI feature New feature or request P0 Critical issue that should get addressed ASAP question Further information is requested v0.30.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jan 22, 2024

Summary

As observed in ProjectEvergreen/www.greenwoodjs.dev#9, it appears that certain URL based CSS features are not bundling (like we do with @import), like in this example for @font-face, which will just yield a 404 in production builds.

 <style>
   @font-face {
     font-family: "Geist-Sans";
     src: url('../../node_modules/geist/dist/fonts/geist-sans/Geist-Regular.woff2') format("truetype");
   }
 </style>

Details

This should bundle (e.g. copy) the file into the build output automatically for @font-face references and ideally thing else that is of type Url

@thescientist13 thescientist13 added question Further information is requested CLI feature New feature or request labels Jan 22, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Jan 22, 2024
@thescientist13 thescientist13 self-assigned this Jan 22, 2024
@thescientist13 thescientist13 changed the title support bundling of @font-face src property during CSS file optimization support bundling of url properties (like for @font-face + src) during CSS file optimization Feb 25, 2024
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 9 - Standards and Conventions Feb 25, 2024
@thescientist13 thescientist13 linked a pull request Mar 16, 2024 that will close this issue
8 tasks
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Mar 16, 2024
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Apr 29, 2024
@thescientist13 thescientist13 linked a pull request May 18, 2024 that will close this issue
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.2 CLI feature New feature or request P0 Critical issue that should get addressed ASAP question Further information is requested v0.30.0
Projects
No open projects
1 participant