-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/issue 1199 url
references in CSS bundling
#1211
Merged
thescientist13
merged 8 commits into
release/0.30.0
from
feature/issue-1199-CSS-url-asset-bundling
May 4, 2024
Merged
feature/issue 1199 url
references in CSS bundling
#1211
thescientist13
merged 8 commits into
release/0.30.0
from
feature/issue-1199-CSS-url-asset-bundling
May 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
Greenwood specific docs
CLI
feature
New feature or request
labels
Mar 15, 2024
thescientist13
changed the title
Feature/issue 1199 css url asset bundling
Feature/issue 1199 Mar 16, 2024
url
references in CSS bundling
thescientist13
changed the title
Feature/issue 1199
feature/issue 1199 May 4, 2024
url
references in CSS bundlingurl
references in CSS bundling
thescientist13
force-pushed
the
feature/issue-1199-CSS-url-asset-bundling
branch
from
May 4, 2024 22:21
b4ca9bd
to
ac17ae1
Compare
thescientist13
added a commit
that referenced
this pull request
Jun 1, 2024
* bundling of URL referenced assets in CSS files * add test cases for CSS url reference bundling * normalize file paths for windows * base path support * hashing of bundled CSS filenames * document CSS bundling behaviors * filename hashing * refactoring and console log cleanup
thescientist13
added a commit
that referenced
this pull request
Nov 2, 2024
* bundling of URL referenced assets in CSS files * add test cases for CSS url reference bundling * normalize file paths for windows * base path support * hashing of bundled CSS filenames * document CSS bundling behaviors * filename hashing * refactoring and console log cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLI
documentation
Greenwood specific docs
feature
New feature or request
question
Further information is requested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1199
Summary of Changes
url
references in CSS files with hashed filenamesTODO
<style>
scratch dir assets handling and test casebasePath
supportQuestions
url
references to assuming the root of the user's workspace when dealing with relative paths, e.g.../
? - I think it's fine for now, if it breaks later on a particular use case, we can improve it then with a clear reproductionwith { type: 'css' }
- tracking in apply CSS optimizations and bundling to CSS (in) modules #1227