-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/issue 946 decouple build and serve commands from workspace #1079
Merged
thescientist13
merged 27 commits into
release/0.28.0
from
enhancement/issue-946-decouple-serve-command-from-workspace
Apr 1, 2023
Merged
Enhancement/issue 946 decouple build and serve commands from workspace #1079
thescientist13
merged 27 commits into
release/0.28.0
from
enhancement/issue-946-decouple-serve-command-from-workspace
Apr 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
question
Further information is requested
RFC
Proposal and changes to workflows, architecture, APIs, etc
CLI
SSR
feature
New feature or request
v0.28.0
labels
Mar 7, 2023
thescientist13
changed the title
Enhancement/issue 946 decouple serve command from workspace
Enhancement/issue 946 decouple build and serve commands from workspace
Mar 7, 2023
thescientist13
commented
Mar 7, 2023
packages/cli/package.json
Outdated
@@ -24,6 +24,9 @@ | |||
"access": "public" | |||
}, | |||
"dependencies": { | |||
"@web/rollup-plugin-import-meta-assets": "^1.0.0", | |||
"@rollup/plugin-commonjs": "^21.0.0", | |||
"@rollup/plugin-json": "^4.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not super happy about this, but I think I can at least handle two of these on my own if I had to (json and import meta assets). But for now it works. 🤞
thescientist13
added
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
and removed
feature
New feature or request
labels
Mar 7, 2023
This was referenced Mar 27, 2023
thescientist13
force-pushed
the
enhancement/issue-946-decouple-serve-command-from-workspace
branch
from
April 1, 2023 19:11
4f67e73
to
b784db1
Compare
thescientist13
deleted the
enhancement/issue-946-decouple-serve-command-from-workspace
branch
April 1, 2023 21:36
This was referenced Apr 8, 2023
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
#1079) * track APIs as part of compilation.manifest and leverage in API routes resource plugin * API routes bundling * pull API routes from manifest for serve command * bundle SSR routes * WCC bunding in API routes * create copy plugin for manifest.json * refactor SSR route bundling * most templating functions working for SSR templating * fill static and SSR templating working with optimizations * fix SSR title rendering * add support for getUserScripts in SSR * hacky work around to get static router + SSR spec working * enable spec * decouple build command from serve command * add build output as pre-requisite to runngin serve command * document new greenwood serve behavior * refactor SSR compilation context bundle output * refactor plugin-standard-html to use template utils * create custom json transformation transformer to handle escodegen * create custom json transformation transformer to handle escodegen * support context plugins in SSR templating * TODO tracking and console log cleanup * upgrade latest wcc with HTML wrapping tag disabled * fix linting * fix path references * normalize SSR static router hack pathnames for windows * normalize SSR static router hack pathnames for windows
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
#1079) * track APIs as part of compilation.manifest and leverage in API routes resource plugin * API routes bundling * pull API routes from manifest for serve command * bundle SSR routes * WCC bunding in API routes * create copy plugin for manifest.json * refactor SSR route bundling * most templating functions working for SSR templating * fill static and SSR templating working with optimizations * fix SSR title rendering * add support for getUserScripts in SSR * hacky work around to get static router + SSR spec working * enable spec * decouple build command from serve command * add build output as pre-requisite to runngin serve command * document new greenwood serve behavior * refactor SSR compilation context bundle output * refactor plugin-standard-html to use template utils * create custom json transformation transformer to handle escodegen * create custom json transformation transformer to handle escodegen * support context plugins in SSR templating * TODO tracking and console log cleanup * upgrade latest wcc with HTML wrapping tag disabled * fix linting * fix path references * normalize SSR static router hack pathnames for windows * normalize SSR static router hack pathnames for windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
CLI
documentation
Greenwood specific docs
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
RFC
Proposal and changes to workflows, architecture, APIs, etc
SSR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #946
Summary of Changes
serve
command + hybrid server using graph.json and manifest.json to manage serving API routes and SSR pagesserve
command from runningbuild
andserve
(greenwood serve
now requires that agreenwood build
has been run)templateDir
to contextTODO
serve
command from bundle lifecycle and add test case in /cli/src/index.js and update specsStatic Router spec failing / conflicting (seems to be because of needing to scaffold lib/router.js)renderToString
wcc#114templatesDir
contextjsonThoughts / Questions / Enhancements Tracking
3.x
#1087fs/promises
-[@rollup/plugin-node-resolve] error detecte if a string matches the name of a Node.js builtin module rollup/plugins#1120
3.x
#1087require
of _package.json_ complicates bundling estools/escodegen#455URL
plugin implementation (seems easy enough)