Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port was hardcoded with serve command and SSR #1092

Merged
merged 1 commit into from
Apr 9, 2023
Merged

port was hardcoded with serve command and SSR #1092

merged 1 commit into from
Apr 9, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 8, 2023 •
edited
Loading

Related Issue

#1079

Summary of Changes

  1. Use port from configuration when using serve command with SSR pages / API
  2. Fixed an errant reference to @greenwood/cli inside a lib file

@thescientist13 thescientist13 added bug Something isn't working CLI SSR v0.28.0 labels Apr 8, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 8, 2023
@thescientist13 thescientist13 changed the title port was hardcoded with serve command and SSR port was hardcoded with serve command and SSR Apr 8, 2023
@thescientist13 thescientist13 self-assigned this Apr 8, 2023
@thescientist13 thescientist13 mentioned this pull request Apr 8, 2023
Merged
22 tasks
@thescientist13 thescientist13 force-pushed the bug/hardcoded-port-with-serve-command-and-SSR branch from 90faa02 to f008e6e Compare April 9, 2023 00:15
@thescientist13 thescientist13 merged commit 4290c3a into release/0.28.0 Apr 9, 2023
@thescientist13 thescientist13 deleted the bug/hardcoded-port-with-serve-command-and-SSR branch April 9, 2023 00:38
thescientist13 added a commit that referenced this pull request Apr 9, 2023
@thescientist13
port was hardcoded with serve command and SSR (#1092)
23d660e
thescientist13 added a commit that referenced this pull request Apr 9, 2023
@thescientist13
port was hardcoded with serve command and SSR (#1092)
42a1035
@thescientist13 thescientist13 mentioned this pull request Apr 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI SSR v0.28.0
Projects
No open projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13