Feature/issue 1116 base path configuration #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
5 tasks
thescientist13
force-pushed
the
feature/issue-1116-base-path-configuration
branch
from
f86c248
to
6a598a3
Compare
thescientist13
commented
Oct 27, 2023
www/templates/app.html
Outdated
| @@ -4,6 +4,7 @@ | |||
| <head> | |||
| <title>Greenwood - ${globalThis.page.title}</title> | |||
| <meta charset="utf-8"> | |||
| <base href="/my-subpath/"/> | |||
There was a problem hiding this comment.
note: this isn't actually doing anything
thescientist13
commented
Oct 27, 2023
| @@ -157,6 +157,11 @@ async function getAppTemplate(pageTemplateContents, context, customImports = [], | |||
| ? appBody.replace(/<page-outlet><\/page-outlet>/, pageBody) | |||
| : appBody; | |||
|
|
|||
| const basePathTag = basePath === '' | |||
There was a problem hiding this comment.
note: this isn't actually doing anything
thescientist13
force-pushed
the
feature/issue-1116-base-path-configuration
branch
from
0646400
to
dda51e5
Compare
thescientist13
added a commit
that referenced
this pull request
Nov 9, 2023
* base path configuration support WIP * base path examples * refactor base configuraton within the graph * integrate base path into script, style and link tags * inegrate base path into graphql plugin * integrate base path into static router * all test cases passing * display base path in server URL terminal output * add base path documentation * handle route depths and base path in graphql resolvers * refactor graphql route depths and base path handling * add basic base path test cases for develop and serve commands * fix linting * remove describe.only * upgrade github pages docs with base path callout and configuration * add image tag example to manual base path prefixing in docs * add base path config serve based test cases * refactor test cases to use fetch * flesh out base path test cases for proxies, API routes, and SSR pages * refactor specs to use fetch * add base path support to adapter plugins * restore post rebase misses * have CLI serialize base path into all pages * document base path persistance * remove demo code
This was referenced Dec 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1116 (and #273)
Summary of Changes
basePathsupport to greenwood.config.js (covers pages, API routes, and adapter routing,<script>and<link>tags, and GraphQL queries)<script>tagTODO
greenwood build/greenwood serve/graph.jsonmargin: autoand navigation issues on the docs websitedevelopservegraphqlstatic routerbasePathfor server logging outputbasePathsupport greenwood-demo-github-pages#1Questions
<base href="..."/>(make discussion) - Enhance `basePath` configuration with `<base href="...">` support #1175