Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/upgrade greenwood v0.29.0 #66

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Sep 30, 2023

Related Issue

N / A

Summary of Changes

  1. Upgrade Greenwood v0.29.0

TODO

  1. Need to incorporate basePath config into fetch for graph.json
      diff --git a/node_modules/greenwood-starter-presentation/dist/layouts/index.html b/node_modules/greenwood-starter-presentation/dist/layouts/index.html
index f12ed80..ea6e11c 100644
--- a/node_modules/greenwood-starter-presentation/dist/layouts/index.html
+++ b/node_modules/greenwood-starter-presentation/dist/layouts/index.html
@@ -5,7 +5,10 @@
     <script type="module" src="/node_modules/greenwood-starter-presentation/dist/components/slide-list.js"></script>
     <script type="module" src="/node_modules/greenwood-starter-presentation/dist/components/slide-viewer.js"></script>
     <script type="module">
-      fetch('/graph.json')
+      const basePath = globalThis.__GWD_BASE_PATH__ || '';
+      console.log({ basePath });
+
+      fetch(`${basePath}/graph.json`)
         .then((response) => response.json())
         .then((response) => {
           // auto generated default page by Greenwood
    

@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for awesome-bhaskara-b7d76c ready!

Name Link
🔨 Latest commit ff60e47
🔍 Latest deploy log https://app.netlify.com/sites/awesome-bhaskara-b7d76c/deploys/654c4490fa937800083525b2
😎 Deploy Preview https://deploy-preview-66--awesome-bhaskara-b7d76c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 changed the title chore/upgrade greenwood v0.29.0-alpha.4 chore/upgrade greenwood v0.29.0 Oct 31, 2023
@thescientist13 thescientist13 marked this pull request as ready for review November 4, 2023 14:35
@thescientist13 thescientist13 merged commit a36b4f7 into master Nov 9, 2023
6 checks passed
@thescientist13 thescientist13 deleted the chore/upgrade-greenwood-v0.29.0 branch November 9, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant