enhancement/Issue 1171: Include protocol with logged urls in terminal output #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevLab2425
changed the title
thescientist13
added
enhancement
thescientist13
approved these changes
Oct 19, 2023
2 tasks
thescientist13
changed the title
DevLab2425
force-pushed
the
issue-1171-active-console-links
branch
from
37c080d
to
aef6f38
Compare
@thescientist13 I've updated the target here. When it's ready, feel free to take it from here. |
|
Thanks @DevLab2425 ! Will leave it open for a couple days for other folks to review and then I'll take it from there. |
thescientist13
changed the title
| @@ -12,7 +12,7 @@ class PuppeteerServer extends ServerInterface { | |||
| const { port } = this.compilation.config.devServer; | |||
|
|
|||
| (await getDevServer(this.compilation)).listen(port, async () => { | |||
| console.info(`Started puppeteer prerender server at localhost:${port}`); | |||
| console.info(`Started puppeteer prerender server at http://localhost:${port}`); | |||
There was a problem hiding this comment.
This one probably won't ever get used by the user (just run at build time) but can't hurt!
thescientist13
merged commit 9135961
into
ProjectEvergreen:release/0.29.0
8 checks passed
thescientist13
pushed a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1171
Summary of Changes
http://protocol on console logs used during server startup.