Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/Issue 1171: Include protocol with logged urls in terminal output #1173

Merged
merged 1 commit into from
Oct 26, 2023
Merged

enhancement/Issue 1171: Include protocol with logged urls in terminal output #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/commands/develop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const runDevServer = async (compilation) => {

(await getDevServer(compilation)).listen(port, () => {

console.info(`Started local development server at localhost:${port}`);
console.info(`Started local development server at http://localhost:${port}`);

const servers = [...compilation.config.plugins.filter((plugin) => {
return plugin.type === 'server';
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const runProdServer = async (compilation) => {
const server = (hasDynamicRoutes && !compilation.config.prerender) || hasApisDir ? getHybridServer : getStaticServer;

(await server(compilation)).listen(port, () => {
console.info(`Started server at localhost:${port}`);
console.info(`Started server at http://localhost:${port}`);
});
} catch (err) {
reject(err);
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-renderer-puppeteer/src/plugins/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class PuppeteerServer extends ServerInterface {
const { port } = this.compilation.config.devServer;

(await getDevServer(this.compilation)).listen(port, async () => {
console.info(`Started puppeteer prerender server at localhost:${port}`);
console.info(`Started puppeteer prerender server at http://localhost:${port}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one probably won't ever get used by the user (just run at build time) but can't hurt!

});
} else {
await Promise.resolve();
Expand Down
Loading