add import and directory support to export map subpath exports #672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #671
Summary of Changes
importMap
import
Discussion
I'm thinking now, based on the nature of this fix, if we actually stillvneed
walkModule
to manually crawl all theimport
s andexport
s of every dependency to add to theimportMap
?. I would be curious to try now with this bug fix to see if ourimportMap
still works without it? Maybe should happen as part of a minor release though, so this PR can just go out as a patch.Additionally, not sure if a sub path export is a directory, does that mean we should recursively export everything? Could be part of an issue that also addresses the above question re:
walkModule
, which coincidentally, I've playing around with in #668Update: made a quick test ( #672 (comment) ) so seems like it is still needed.