-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade website to lit@2
#611
upgrade website to lit@2
#611
Conversation
lit@2
support
lit@2
supportlit@2
support (wildcard export
all declaration support)
lit@2
support (wildcard export
all declaration support)lit@2
support and wildcard export
all declaration support
lit@2
support and wildcard export
all declaration supportlit@2
209feae
to
30c661c
Compare
@hutchgrant |
Hmm, (only?) after rebasing it seems that occasionally the manifestation of #675 comes back, even though Shady DOM looks correct in the raw HTML Will have to test on the pre-rebase branch to see if I can reproduce or not and if it's perhaps a Lit regression or not? |
b60c1a3
to
8969fa0
Compare
Latest UpdateNot not able to reproduce #611 (comment) after 10 local runs so thinking things are OK so will push a rebase up, but also thinking a couple more things might help improve stability Lit Versions / ResolutionsCurrently there are multiple copies of Lit and libs because a number of packages are on rc release % yarn why lit
yarn why v1.22.5
[1/4] 🤔 Why do we have the module "lit"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "lit@2.0.0-rc.2"
info Has been hoisted to "lit"
info Reasons this module exists
- "workspace-aggregator-c98fa550-b58a-4b7e-926a-1d051b41a008" depends on it
- Hoisted from "_project_#@greenwood#www#@evergreen-wc#eve-button#lit"
- Hoisted from "_project_#@greenwood#www#@evergreen-wc#eve-container#lit"
- Hoisted from "_project_#@greenwood#cli#@lion#button#@lion#core#lit"
info Disk size without dependencies: "560KB"
info Disk size with unique dependencies: "3.08MB"
info Disk size with transitive dependencies: "3.11MB"
info Number of shared dependencies: 4
=> Found "@greenwood/cli#lit@2.0.0"
info This module exists because "_project_#@greenwood#cli" depends on it.
=> Found "@greenwood/www#lit@2.0.0"
info This module exists because "_project_#@greenwood#www" depends on it.
✨ Done in 0.98s.
owenbuckley@Owens-MBP-2 greenwood % yarn why lit-html
yarn why v1.22.5
[1/4] 🤔 Why do we have the module "lit-html"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "lit-html@2.0.0"
info Has been hoisted to "lit-html"
info Reasons this module exists
- "workspace-aggregator-e7e16504-8779-4300-9c30-e33c7a221128" depends on it
- Hoisted from "_project_#@greenwood#cli#lit#lit-html"
- Hoisted from "_project_#@greenwood#www#lit#lit-html"
- Hoisted from "_project_#@greenwood#cli#lit#lit-element#lit-html"
- Hoisted from "_project_#@greenwood#www#lit#lit-element#lit-html"
info Disk size without dependencies: "1.29MB"
info Disk size with unique dependencies: "1.32MB"
info Disk size with transitive dependencies: "1.32MB"
info Number of shared dependencies: 1
=> Found "lit#lit-html@2.0.0-rc.3"
info This module exists because "_project_#lit" depends on it.
=> Found "lit-element#lit-html@2.0.0-rc.3"
info This module exists because "_project_#lit#lit-element" depends on it.
✨ Done in 0.92s.
owenbuckley@Owens-MBP-2 greenwood % yarn why lit-element
yarn why v1.22.5
[1/4] 🤔 Why do we have the module "lit-element"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "lit-element@3.0.0-rc.2"
info Reasons this module exists
- "_project_#lit" depends on it
- Hoisted from "_project_#lit#lit-element"
info Disk size without dependencies: "544KB"
info Disk size with unique dependencies: "2.54MB"
info Disk size with transitive dependencies: "2.56MB"
info Number of shared dependencies: 3
=> Found "@greenwood/cli#lit-element@3.0.0"
info Reasons this module exists
- "_project_#@greenwood#cli#lit" depends on it
- Hoisted from "_project_#@greenwood#cli#lit#lit-element"
=> Found "@greenwood/www#lit-element@3.0.0"
info Reasons this module exists
- "_project_#@greenwood#www#lit" depends on it
- Hoisted from "_project_#@greenwood#www#lit#lit-element"
✨ Done in 0.97s. Might opt to leverage Yarn resolutions for now to get something like this % yarn why lit
yarn why v1.22.5
[1/4] 🤔 Why do we have the module "lit"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "lit@2.0.0"
info Reasons this module exists
- "_project_#@greenwood#cli" depends on it
- Hoisted from "_project_#@greenwood#cli#lit"
- Hoisted from "_project_#@greenwood#www#lit"
- Hoisted from "_project_#@greenwood#www#@evergreen-wc#eve-button#lit"
- Hoisted from "_project_#@greenwood#www#@evergreen-wc#eve-container#lit"
- Hoisted from "_project_#@greenwood#cli#@lion#button#@lion#core#lit"
info Disk size without dependencies: "560KB"
info Disk size with unique dependencies: "3.08MB"
info Disk size with transitive dependencies: "3.11MB"
info Number of shared dependencies: 3
✨ Done in 0.95s.
owenbuckley@Owens-MBP-2 greenwood % yarn why lit-html
yarn why v1.22.5
[1/4] 🤔 Why do we have the module "lit-html"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "lit-html@2.0.0"
info Reasons this module exists
- "_project_#@greenwood#cli#lit" depends on it
- Hoisted from "_project_#@greenwood#cli#lit#lit-html"
- Hoisted from "_project_#@greenwood#cli#lit#lit-element#lit-html"
info Disk size without dependencies: "1.29MB"
info Disk size with unique dependencies: "1.32MB"
info Disk size with transitive dependencies: "1.32MB"
info Number of shared dependencies: 1
✨ Done in 0.85s.
owenbuckley@Owens-MBP-2 greenwood % yarn why lit-element
yarn why v1.22.5
[1/4] 🤔 Why do we have the module "lit-element"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "lit-element@3.0.0"
info Reasons this module exists
- "_project_#@greenwood#cli#lit" depends on it
- Hoisted from "_project_#@greenwood#cli#lit#lit-element"
info Disk size without dependencies: "544KB"
info Disk size with unique dependencies: "2.54MB"
info Disk size with transitive dependencies: "2.56MB"
info Number of shared dependencies: 2
✨ Done in 0.89s. This should also help eliminate duplicate bundles, as it looks like eve-container is bundling its own version of lit Should open up issues on our dependencies to get everything aligned on the @webcomponents bundleThis would be a good time to update to the latest version (2.6.0). |
Related Issue
related to this discussion on SSR
#576 and includes fix for #675
In order for the website, using Lit to benefit from SSR, we would need to be on the latest version so figured I would start work on the discussion by introducing Lit@2 as a first step
Summary of Changes
ExportAllDeclaration
case when walking a module with acornimportMap
and added bare import "re-map" supportAlso, LitElement bundle size dropped significantly, going from 27KB -> 15KB! ⚡
TODO
lit@2
hutchgrant/evergreen-web-components#33Lit@2
fernandopasik/lit-redux-router#55mode
specLit@2
is out of RC)lit-redux-router- already bumped, and updated the project hereAs this has a couple upstream dependencies, it may be worth considering breaking out the rollup.config.js change from this PR.