Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 7 open props #38

Merged
merged 3 commits into from
May 3, 2024
Merged

enhancement/issue 7 open props #38

merged 3 commits into from
May 3, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 29, 2024

Related Issue

relates to #7

Summary of Changes

  1. Introduce Open Props for standard design system tokens and apply to our theme.css and general usage
  2. Document usage in our Storybook docs

Ultimately, I think final strategy will be a combination of Open Props and CSS Modules ™️

Deploy Preview - https://deploy-preview-38--super-tapioca-5987ce.netlify.app/

Screenshot 2024-04-29 at 4 39 56 PM
Screenshot 2024-04-29 at 4 41 46 PM


Needs support for bundling where(xxx) selector in CSS which is tracked here in Greenwood - ProjectEvergreen/greenwood#1178, so will add it to #37 and see if we can get this escalated for the next Greenwood release.

@thescientist13 thescientist13 added docs Greenwood specific documentation enhancement New feature or request needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) labels Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit aa52c20
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/6635167bbf620e000880d2bf
😎 Deploy Preview https://deploy-preview-38--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 requested review from Auhseh and a team April 30, 2024 00:20
@thescientist13 thescientist13 merged commit 5b50fac into main May 3, 2024
5 checks passed
@thescientist13 thescientist13 deleted the open-props branch May 3, 2024 16:55
@thescientist13 thescientist13 mentioned this pull request May 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific documentation enhancement New feature or request needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood)
Projects
Development

Successfully merging this pull request may close these issues.

2 participants