Fix SwitchRow subtitles #1352
Merged
Fix SwitchRow subtitles #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -60,7 +60,8 @@ final class CoreOptionsViewController: QuickTableViewController { | |||
| let rows: [TableRow] = $0.options.map { option in | |||
| switch option { | |||
| case let .bool(display, defaultValue): | |||
| return SwitchRow(text: display.title, detailText: .none, switchValue: core.valueForOption(Bool.self, option.key) ?? defaultValue, action: { _ in | |||
| let detailText: DetailText = display.description != nil ? DetailText.subtitle(display.description!) : .none | |||
| return SwitchRow(text: display.title, detailText: detailText, switchValue: core.valueForOption(Bool.self, option.key) ?? defaultValue, action: { _ in | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 169 characters (line_length)
| @@ -60,7 +60,8 @@ final class CoreOptionsViewController: QuickTableViewController { | |||
| let rows: [TableRow] = $0.options.map { option in | |||
| switch option { | |||
| case let .bool(display, defaultValue): | |||
| return SwitchRow(text: display.title, detailText: .none, switchValue: core.valueForOption(Bool.self, option.key) ?? defaultValue, action: { _ in | |||
| let detailText: DetailText = display.description != nil ? DetailText.subtitle(display.description!) : .none | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)
jasarien
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request uses the
display.descriptionvariable as the SwitchRow subtitle if available (like with the .multi option).It is dependent on QuickTableViewController v1.2.2 which includes bcylin/QuickTableViewController#45 so Carthage must be updated.
Before:
After:
