Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SwitchRow subtitles #45

Merged
merged 4 commits into from
May 23, 2020
Merged

Fix SwitchRow subtitles #45

merged 4 commits into from
May 23, 2020

Conversation

dnicolson
Copy link
Contributor

This pull request enables SwitchRow subtitles, previously the detailText value would not be displayed.

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #45 into develop will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    95.10%   94.87%   -0.23%     
===========================================
  Files           14       14              
  Lines          347      332      -15     
===========================================
- Hits           330      315      -15     
  Misses          17       17              
Impacted Files Coverage Δ
Source/Rows/SwitchRow.swift 100.00% <100.00%> (ø)
Source/QuickTableViewController.swift 89.18% <0.00%> (-1.06%) ⬇️
Source/Model/RadioSection.swift 94.73% <0.00%> (-0.62%) ⬇️
Source/Protocol/Reusable.swift 100.00% <0.00%> (ø)
Source/Protocol/Configurable.swift 100.00% <0.00%> (ø)

Source/Rows/SwitchRow.swift Outdated Show resolved Hide resolved
Source/Rows/SwitchRow.swift Outdated Show resolved Hide resolved
dnicolson and others added 3 commits May 22, 2020 21:54
Co-authored-by: Ben <b.cylin@gmail.com>
Co-authored-by: Ben <b.cylin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants