Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCode15 / iOS17: Add 3DS Support through EmuThreeds / Update Play! PS2 to latest code #2210

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

rf2222222
Copy link
Contributor

@rf2222222 rf2222222 commented Jun 29, 2023

What does this PR do

  • Added emuthreed to play 3DS games
  • Added 3DS touch screen controller
  • Update Play! to latest GitHub (provides improved sound compared to before)
  • Prevent game from being moved into conflicts folder during artwork download
  • Added RxRealm as library with XCode15 Beta6 patches
  • Update Flycast to latest GitHub tree, with Vulkan support
  • Added Sound Volume Control Option to RetroArch, Emuthreeds, Play, etc
  • LZH / RAR / ZIP archive load support for NP2Kai to play PC98 games with boot disk from archive (extracted files saved to Battery States)
  • Zip archive load / Play support for DosBox / NeoGeo / MAME
  • Optimized ROM import w/ Caching in RomDatabase, added 'Refresh' button to scan / update the game library w/ new rom
  • Various updates to GameLibrary interfaces to work / appear ok on iOS17
  • Added Apple IIe core support via MAME
  • Added MAME / NeoGeo touchscreen controller
  • Vulkan is now the default graphics renderer on PPSSPP

On iOS17 AltKit does not work, so to enable JIT:

  1. Launch Provenance XL Release on iPhone/iPad, Launch XCode15, select the iPhone/iPad
  2. Debug -> Attach to Process by PID or Name
  3. Enter "Provenance XL" (assuming Provenance XL Release is installed), Click Attach. After confirming the game (PS2, Wii, etc) is working, Debug -> Detach from Provenance XL

Where should the reviewer start

emuthreed (should play) -> Play!

How should this be manually tested

Play .3DS games with emuthreed, Play! offers more games compatibility

Any background context you want to provide

What are the relevant tickets

#2201

Screenshots (important for UI changes)

IMG_0930
IMG_0934
IMG_0936

Questions

@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@rf2222222 rf2222222 force-pushed the xcode15beta2 branch 4 times, most recently from 2c13463 to c941b5d Compare July 1, 2023 21:32
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@rf2222222 rf2222222 force-pushed the xcode15beta2 branch 3 times, most recently from 95be5db to 41503f6 Compare July 3, 2023 21:33
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@rf2222222 rf2222222 force-pushed the xcode15beta2 branch 2 times, most recently from b594eb1 to 08bfa62 Compare July 8, 2023 17:19
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@rf2222222 rf2222222 changed the title XCode15 Beta2: Adjust SourceView Location on UIAlertController XCode15 Beta2: Adjust SourceView Location on UIAlertController / Update PS2 to latest GitHub Jul 8, 2023
@rf2222222 rf2222222 changed the title XCode15 Beta2: Adjust SourceView Location on UIAlertController / Update PS2 to latest GitHub XCode15 Beta2: Adjust SourceView Location on UIAlertController / Update PS2 to latest code Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@rf2222222 rf2222222 force-pushed the xcode15beta2 branch 3 times, most recently from 026cd07 to 5e31cb5 Compare July 10, 2023 06:44
@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@rf2222222 rf2222222 changed the title XCode15 Beta2: Adjust SourceView Location on UIAlertController / Update PS2 to latest code XCode15 Beta2: Update PS2 to latest code / Adjust SourceView Location on UIAlertController Jul 24, 2023
@rf2222222 rf2222222 force-pushed the xcode15beta2 branch 4 times, most recently from 0a8b98a to e4b3526 Compare July 30, 2023 00:40
@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@denisoster
Copy link

Please add dreamcast and gamecube for AppleTV

@rf2222222
Copy link
Contributor Author

Please add dreamcast and gamecube for AppleTV

I personally don’t own an AppleTV device, so the best bet is to build the sources for AppleTV =] :
Dreamcast (Flycast): https://github.com/flyinghead/flycast
GameCube / Wii (Dolphin iOS): https://github.com/OatmealDome/dolphin-ios

@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@denisoster
Copy link

Please add support tv17

@rf2222222
Copy link
Contributor Author

Please add support tv17

The "ProvenanceTV - Release" schema should run on tvOS17. =]

@rf2222222 rf2222222 mentioned this pull request Sep 29, 2023
@rf2222222
Copy link
Contributor Author

rf2222222 commented Oct 5, 2023

@JoeMatt Now that iOS 17 is released to general public, this has all the fixes related to iOS16 -> iOS17 that fixes various crash issues related to this transition. I’m done with this round of changes related to iOS17 / 3DS Core / PSP updates ..etc so this is all good to go to get merged =]

@gh0sti
Copy link

gh0sti commented Oct 5, 2023

@JoeMatt Now that iOS 17 is released to general public, this has all the fixes related to iOS16 -> iOS17 that fixes various crash issues related to this transition. I’m done with this round of changes related to iOS17 / 3DS Core / PSP updates ..etc so this is all good to go to get merged =]

do you have one last precompiled ipa until Joe can come around and do a merge to branch?

@rf2222222
Copy link
Contributor Author

@JoeMatt Now that iOS 17 is released to general public, this has all the fixes related to iOS16 -> iOS17 that fixes various crash issues related to this transition. I’m done with this round of changes related to iOS17 / 3DS Core / PSP updates ..etc so this is all good to go to get merged =]

do you have one last precompiled ipa until Joe can come around and do a merge to branch?

The last build, #2210 (comment) should be the latest =]

@jwoo92
Copy link

jwoo92 commented Nov 7, 2023

iOS/iPadOS 17.1 introduces support for the Nintendo 64 controller.

It appears only the start button input registers in Provenance. Would someone be kind enough to take a look at working in support within this PR? Thanks.

@Spidy123222
Copy link

Spidy123222 commented Nov 10, 2023

Please add support tv17

The "ProvenanceTV - Release" schema should run on tvOS17. =]

Emuthreeds renamed to limon and has been updating more recently. Do you think this pr will get updated to reflect the changes? https://github.com/emuPlace/Limon

@rf2222222
Copy link
Contributor Author

Please add support tv17

The "ProvenanceTV - Release" schema should run on tvOS17. =]

Emuthreeds renamed to limon and has been updating more recently. Do you think this pr will get updated to reflect the changes? https://github.com/emuPlace/Limon

Seems tvOS is very popular request. I might get it in the future if I become popular enough with Apple for them to send me these devices to review as they come out with it =]

Actually talked to Joe about getting this merged so I could put in new features, but haven't heard back. If you get a hold of him and could get him to merge this PR, I could look at it as next Pr =]

@Spidy123222
Copy link

Spidy123222 commented Nov 18, 2023

Please add support tv17

The "ProvenanceTV - Release" schema should run on tvOS17. =]

Emuthreeds renamed to limon and has been updating more recently. Do you think this pr will get updated to reflect the changes? https://github.com/emuPlace/Limon

Seems tvOS is very popular request. I might get it in the future if I become popular enough with Apple for them to send me these devices to review as they come out with it =]

Actually talked to Joe about getting this merged so I could put in new features, but haven't heard back. If you get a hold of him and could get him to merge this PR, I could look at it as next Pr =]

Yeah us at sidestore don't have direct access (outside of GitHub/discord) to Joe as he's part of project also. I'll message him on discord but it could be a while. There was a project started by some people called genesis to maintain a experimental version for the meantime while provenance has been stuck in place for most part for a while. If joematt reads this, I suggest adding people to be able to maintain the app while being gone. TvOS I can see why it's popular. Though I could see it having problems with game size.

@rf2222222
Copy link
Contributor Author

Please add support tv17

The "ProvenanceTV - Release" schema should run on tvOS17. =]

Emuthreeds renamed to limon and has been updating more recently. Do you think this pr will get updated to reflect the changes? https://github.com/emuPlace/Limon

Seems tvOS is very popular request. I might get it in the future if I become popular enough with Apple for them to send me these devices to review as they come out with it =]
Actually talked to Joe about getting this merged so I could put in new features, but haven't heard back. If you get a hold of him and could get him to merge this PR, I could look at it as next Pr =]

Yeah us at sidestore don't have direct access (outside of GitHub/discord) to Joe as he's part of project also. I'll message him on discord but it could be a while. There was a project started by some people called genesis to maintain a experimental version for the meantime while provenance has been stuck in place for most part for a while. If joematt reads this, I suggest adding people to be able to maintain the app while being gone. TvOS I can see why it's popular. Though I could see it having problems with game size.

Yeah can you let them know I’ll maintain Provenance / get these PRs merged / get to bug fixing if they’re willing to grant the admin permission. (The donation / proceeds generated by Provenance are still theirs to keep) It’s been a while =]

@JoeMatt
Copy link
Member

JoeMatt commented Jan 3, 2024

This builds for me on XCode Version 15.1 (15C65)

Amazing work. I want to check if this merges well with @dnicolson 's PRs too and see if merge/rebase order matters.

Will try to keep things as clean as possible.

Since the amount of changes is massive, but it works, I'm leaning towards restarting all my previous side work on SPM and stuff later based on this and dni's changes too and then also reviewing if i want to 'correct' any changes after the fact on 'develop' rather than take days to review the pr's one by one and merging one by one etc

@JoeMatt JoeMatt self-assigned this Jan 3, 2024
@JoeMatt JoeMatt added this to the 2.3.0 milestone Jan 3, 2024
@JoeMatt JoeMatt merged commit 2083012 into Provenance-Emu:develop Jan 3, 2024
7 of 8 checks passed
@pokemon-card
Copy link

Any way to increase fps on emuthreeds?

@rf2222222
Copy link
Contributor Author

Any way to increase fps on emuthreeds?

@pokemon-card The project repository has latest and code base that is always getting updated. This is at:

https://emuthreeds.com/
https://github.com/emuplace/limon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.