Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix game pause alert #2239

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Fix game pause alert #2239

merged 3 commits into from
Jan 4, 2024

Conversation

dnicolson
Copy link
Contributor

What does this PR do

Fixes the alert when the game is paused, similar to #2088.

Before and after:
Screenshot 2023-09-28 at 20 30 13 Screenshot 2023-09-28 at 20 31 09

@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Have a nice day.

@rf2222222
Copy link
Contributor

rf2222222 commented Sep 29, 2023 •
edited
Loading

This looks good =] I actually have similar series of changes pending.
The alert interfaces weren’t working with XCode15 on iOS17 on iPad due to new requirement introduced on XCode15 to require source/baritem for popoveralert (which.. is fixed by not having it be popover and instead a full screen dialogue) so… the TVAlertController’s modified to work along with… a lot of other changes in.. #2210 <— This PR. (Also revises import/logging/pvlibrary/game library/search interface/settings interfaces/game library pop up interface options ..etc in a very significant way so.. it’s probably good timing to get all these PRs merged now) @dnicolson @JoeMatt

@dnicolson dnicolson mentioned this pull request Oct 1, 2023
Merged
@JoeMatt JoeMatt self-assigned this Jan 3, 2024
@JoeMatt JoeMatt added the needs cleaning commit conflicts (entitlements, bundleIDs, app-groups, etc) to remove or clean up label Jan 3, 2024
JoeMatt
JoeMatt previously approved these changes Jan 3, 2024
View reviewed changes
@JoeMatt JoeMatt removed the needs cleaning commit conflicts (entitlements, bundleIDs, app-groups, etc) to remove or clean up label Jan 3, 2024
@JoeMatt JoeMatt added this to the 2.3.0 milestone Jan 3, 2024
@JoeMatt JoeMatt added ui/ux related to user interface and experience autosquash Bot will automatically squash and merge PRs after all checks and approvals are passed. labels Jan 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Builds for this Pull Request are available at
Provenance.ipa
ProvenanceTV.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@JoeMatt JoeMatt self-requested a review January 4, 2024 00:57
@JoeMatt JoeMatt merged commit 2c91f47 into Provenance-Emu:develop Jan 4, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeMatt JoeMatt JoeMatt approved these changes

@jasarien jasarien Awaiting requested review from jasarien jasarien is a code owner

Assignees

@JoeMatt JoeMatt

Labels
autosquash Bot will automatically squash and merge PRs after all checks and approvals are passed. ui/ux related to user interface and experience
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnicolson @rf2222222 @JoeMatt