Fix poetry pip-shims extras dependency #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With poetry-core>=1.5.0, the dependencies in extras must be present in the main dependency group.
jooola
changed the title
jooola
changed the title
|
Alright, who's got the pager? |
|
To prevent something like this from happening again, maybe isort's pyproject.toml should pin a specific version of poetry-core. |
timothycrosley
approved these changes
Jan 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 38 38
Lines 3091 3091
Branches 747 747
=======================================
Hits 3067 3067
Misses 14 14
Partials 10 10 |
7 tasks
hugovk
added a commit
to hugovk/em-keyboard
that referenced
this pull request
Jan 29, 2023
hugovk
added a commit
to hugovk/github-tools
that referenced
this pull request
Jan 29, 2023
hugovk
added a commit
to hugovk/gutenberg-metadata
that referenced
this pull request
Jan 29, 2023
hugovk
added a commit
to hugovk/hugovk
that referenced
this pull request
Jan 29, 2023
hugovk
added a commit
to hugovk/lastfm-tools
that referenced
this pull request
Jan 29, 2023
This was referenced Jan 29, 2023
4 tasks
kgrant-rh
pushed a commit
to RedHatProductSecurity/osidb
that referenced
this pull request
Feb 13, 2023
This was referenced Feb 20, 2023
jalaziz
added a commit
to jalaziz/django-rest-framework
that referenced
this pull request
Feb 22, 2023
This fixes recent issues with installing isort via pre-commit that was introduced in recent versions of poetry-core. See PyCQA/isort#2078
auvipy
pushed a commit
to encode/django-rest-framework
that referenced
this pull request
Feb 22, 2023
This fixes recent issues with installing isort via pre-commit that was introduced in recent versions of poetry-core. See PyCQA/isort#2078
zamberjo
pushed a commit
to aurestic/oca-addons-repo-template
that referenced
this pull request
Feb 22, 2023
See PyCQA/isort#2077 and PyCQA/isort#2078 which are fixed by this release.
gadomski
added a commit
to stac-utils/stac-fastapi-pgstac
that referenced
this pull request
Mar 22, 2023
* deps: bump pre-commit dep versions Needed to pick up PyCQA/isort#2078 * lint: rename some ambiguous variables
markvader
added a commit
to markvader/ha-rpi_rf
that referenced
this pull request
Apr 3, 2023
an-ky
added a commit
to an-ky/pytest-testinfra
that referenced
this pull request
May 9, 2023
Running tox results in an error message: > Configuration is invalid: > - [extras.pipfile_deprecated_finder.2] \ > 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$' This is caused by additional checks in poetry-core >= 1.5.0 and fixed fixed by PyCQA/isort#2078
philpep
pushed a commit
to pytest-dev/pytest-testinfra
that referenced
this pull request
May 19, 2023
Running tox results in an error message: > Configuration is invalid: > - [extras.pipfile_deprecated_finder.2] \ > 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$' This is caused by additional checks in poetry-core >= 1.5.0 and fixed fixed by PyCQA/isort#2078
sherbang
added a commit
to gozynta/pre-commit-hooks
that referenced
this pull request
Jun 11, 2023
Particularly upgrade isort to fix dependency issue. PyCQA/isort#2078
hrodmn
added a commit
to ncx-co/threedep
that referenced
this pull request
Jul 21, 2023
this fixes an error during isort installation PyCQA/isort#2078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With poetry-core>=1.5.0, the dependencies in extras must be present in the main dependency group.
Fix #2077