Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mis specified dependency #1919

Merged
merged 11 commits into from
Jan 28, 2023
Merged

Fixes mis specified dependency #1919

merged 11 commits into from
Jan 28, 2023

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Jan 28, 2023

What does this PR do?

Fixes a mis specified dependency that results in installation from source failing with 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers. Is likely related to the latest release of setuptools (https://setuptools.pypa.io/en/latest/history.html#v67-0-0), but I'm not sure what the dependency path is that leads us there, as this fails without changing anything about the environment it is running in (i.e. did not upgrade any packages, and setuptools is pinned to 0.59.5 in the environment i'm running in).

isort also broke so requires an upgrade: PyCQA/isort#2078

This also requires moving the pip install out of the mcli integration, so that it can pick up changes to setup.py before installing.

What issue(s) does this change relate to?

Closes CO-1701

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg changed the title Setuptools Fixes mis specified dependency Jan 28, 2023
@dakinggg dakinggg marked this pull request as ready for review January 28, 2023 21:42
@dakinggg dakinggg requested a review from a team as a code owner January 28, 2023 21:42
@dakinggg dakinggg requested a review from mvpatel2000 January 28, 2023 21:54
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for non-GPU tests to pass before merging

@mvpatel2000
Copy link
Contributor

Red button merging as GPU workflow will continue to fail.

This PR updates workflow to pip install after checking out branch, which means it will correctly use the right setup.py in future. However, pull_request_target workflows are not updated in PRs from fork, so it will not be able to be patched to pass tests here. GPU workflow is new so some problems like this are expected

@mvpatel2000 mvpatel2000 merged commit 344b56a into mosaicml:dev Jan 28, 2023
@dakinggg dakinggg deleted the setuptools branch September 9, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants