Update handling of breaking around binary operators: W503 vs W504 #498

IanLee1521 · 2016-04-15T17:26:34Z

Based on the discussion that started on python-dev [1] and ended with an update to PEP-8 [2][3], the logic for allowing (preferring really) breaks to occur before rather than after binary operators.

[1] https://mail.python.org/pipermail/python-ideas/2016-April/039774.html
[2] http://bugs.python.org/issue26763
[3] https://hg.python.org/peps/rev/3857909d7956

An recent update[1] on PEP8 allows to break a line before a binary operator, until pep8 is updated[2] to reflect to that change, let's ignore it. [1] https://hg.python.org/peps/rev/3857909d7956 [2] PyCQA/pycodestyle#498

hai-ld · 2016-04-20T06:54:15Z

How should we implement this patch, interface-wise? There are two options off the top of my head:

provide an option to choose the preferred breaking style, with the new style as default
or warning when inspected files containing both styles

methane · 2016-04-20T07:06:48Z

My opinion is just stop warning and more permissive about continuation line.
Current pydocstyle is stricter than Guido. There are many cases "this is more readable, but pep8.py doesn't accept it."

See discussion in http://bugs.python.org/issue26763

warsaw · 2016-04-20T13:10:40Z

I also lean toward not warning about it. It seems like it might be good to warn about mixed styles, but I think ultimately that will be more annoying than helpful.

Closes PyCQA#498

sigmavirus24 · 2016-04-20T13:34:56Z

#499 is the most straight forward way of solving this. This also allows others who like this rule to re-enable it by selecting it.

hai-ld · 2016-04-21T04:16:49Z

@sigmavirus24 If I understand it correctly, that means there is no way to:

ensure consistent breaking
enforce breaking before binary operator

Is it PyCQA's opinion that above points should be pylint's responsibilities?

sigmavirus24 · 2016-04-21T12:59:32Z

@hai-ld please don't put words in my mouth. The immediate need is to turn this off. In my opinion a new check should be added which is also in the default ignore, otherwise we will cause a lot of problems. This means people will need to enable it by hand. (That said, if we wanted to add the new check in pycodestyle 2.0 we could break it very easily.)

hai-ld · 2016-04-21T15:57:49Z

@sigmavirus24 I'm sorry if there's any negative connotation in my comments, be assured that it's not intentional (I'm just not a native English speaker). Since you said "#499 is the most straight forward way of solving this", I thought that was the final solution and asked for confirmation.

sigmavirus24 · 2016-04-21T16:01:52Z

The two comments after yours advocated for not warning about this particular style notion from PEP-0008. In that case, the most straight-forward way to solving the problem of warning about this is to disable it. It's not the end of all discussion though.

Closes PyCQA#498

This flips the W503 rule to enforce line breaks before binary operators. Related PyCQA#498

IanLee1521 · 2016-05-31T17:12:08Z

Re-opening to allow discovery of this issue instead of new issues being opened.

This flips the W503 rule to enforce line breaks before binary operators. Related #498

Our old version of pep8 produces a warning that goes against the actual pep8 style guide: https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator PyCQA/pycodestyle#498 Change-Id: Iea4612a6608f9de25a1a85c201e5ccc936ec35b7

2.2.0 (2016-11-14) ------------------ Bugs: * Fixed E305 regression caused by PyCQA#400; PyCQA#593 2.1.0 (2016-11-04) ------------------ Changes: * Report E302 for blank lines before an "async def"; PyCQA#556 * Update our list of tested and supported Python versions which are 2.6, 2.7, 3.2, 3.3, 3.4 and 3.5 as well as the nightly Python build and PyPy. * Report E742 and E743 for functions and classes badly named 'l', 'O', or 'I'. * Report E741 on 'global' and 'nonlocal' statements, as well as prohibited single-letter variables. * Deprecated use of `[pep8]` section name in favor of `[pycodestyle]`; PyCQA#591 Bugs: * Fix opt_type AssertionError when using Flake8 2.6.2 and pycodestyle; PyCQA#561 * Require two blank lines after toplevel def, class; PyCQA#536 * Remove accidentally quadratic computation based on the number of colons. This will make pycodestyle faster in some cases; PyCQA#314 2.0.0 (2016-05-31) ------------------ Changes: * Added tox test support for Python 3.5 and pypy3 * Added check E275 for whitespace on `from ... import ...` lines; PyCQA#489 / PyCQA#491 * Added W503 to the list of codes ignored by default ignore list; PyCQA#498 * Removed use of project level `.pep8` configuration file; PyCQA#364 Bugs: * Fixed bug with treating `~` operator as binary; PyCQA#383 / PyCQA#384 * Identify binary operators as unary; PyCQA#484 / PyCQA#485 1.7.0 (2016-01-12) ------------------ Changes: * Reverted the fix in PyCQA#368, "options passed on command line are only ones accepted" feature. This has many unintended consequences in pep8 and flake8 and needs to be reworked when I have more time. * Added support for Python 3.5. (Issue PyCQA#420 & PyCQA#459) * Added support for multi-line config_file option parsing. (Issue PyCQA#429) * Improved parameter parsing. (Issues PyCQA#420 & PyCQA#456) Bugs: * Fixed BytesWarning on Python 3. (Issue PyCQA#459)

Breaks are prefered to occure before rather than after binary operators: PyCQA/pycodestyle#498 W503 has been added to the default ignore list in the latest version, but has to be explicitely specified as we override the default option.

This commit disables warnings W503 and W504. One of these was added to the default ignore list because it wasn't clear, and line breaks conflict with another rule which doesn't allow lines greater than 80 chars. I believe that disabling these rules (W503 + W504) is the cleaner solution. See also discussion here: PyCQA/pycodestyle#498

PyCQA/pycodestyle#498

See: PyCQA/pycodestyle#498

This commit updates code that was styled to comply with [flake8 rule W503](https://lintlyci.github.io/Flake8Rules/rules/W503.html) to comply with [W504](PyCQA/pycodestyle#498) instead.

We removed all default disabled warnings, but then should add back in W503 and W504 (split after binary operator). See PyCQA/pycodestyle#498

* update pycodestyle to fix broken validation * use raw strings for regexp input to satisfy linter The new version of pycodestyle (2.4.0) requires a few more rules to be satisfied, one of which is Python raw strings for regexp's (which is a good idea IMO). This commit updates the regular expressions that were previously not using raw strings, to use them. * disable line break warnings in pycodestyle This commit disables warnings W503 and W504. One of these was added to the default ignore list because it wasn't clear, and line breaks conflict with another rule which doesn't allow lines greater than 80 chars. I believe that disabling these rules (W503 + W504) is the cleaner solution. See also discussion here: PyCQA/pycodestyle#498 * add test to cover DashConfig.slurp_config_file This ensures the method still works as expected after the raw string change in comment filter regex. * submit new simpler format Trigger objects (#43) * removes remaining SHIM_serialise_for_dashd method (not used any longer) * changes serialization format of triggers submitted to the new format, which changed serialized trigger size in a test and uncovered a bug in the size check * fixes a bug in govobj size limit check in superblock creation (use a temp list to check payments, and only add a proposal to the confirmed payments list after size is checked) * calculate reasonable mock gobject size limit in test This removes the hard-coded max size in the test. Due to the proposal serialization format changing, this hard-coded limit won't work now, and the test should be more robust anyway. * remove trigger size limit * update readme, align w/std-README format (#56) Also remove specific versions to align w/new versioning strategy. * bump version for release (#57)

PEP 8 recommends to break a long line after a binary operator. That's used in the current code. In the past PEP 8 wasn't so specific and W504 appeared in flake8. This one makes flake8 ignore W504. For details see PyCQA/pycodestyle#498

Add upper version constraint to apispec and ignore flake8 warning. PyCQA/pycodestyle#498

IanLee1521 added the needs patch label Apr 15, 2016

The-Compiler mentioned this issue Apr 18, 2016

Report W503 for line breaks before binary operators; issue #197. #ep14boat #305

Merged

sigmavirus24 added a commit to sigmavirus24/pep8 that referenced this issue Apr 20, 2016

Add W503 to default ignore list

27d6384

Closes PyCQA#498

sigmavirus24 mentioned this issue Apr 20, 2016

Add W503 to default ignore list #499

Merged

sigmavirus24 added a commit to sigmavirus24/pep8 that referenced this issue Apr 23, 2016

Add W503 to default ignore list

bac13b8

Closes PyCQA#498

IanLee1521 closed this as completed in #499 Apr 28, 2016

sigmavirus24 added a commit to sigmavirus24/pep8 that referenced this issue Apr 30, 2016

Add W504 for line breaks before binary operators

83dd7ea

This flips the W503 rule to enforce line breaks before binary operators. Related PyCQA#498

sigmavirus24 mentioned this issue Apr 30, 2016

Add W504 for line breaks before binary operators #502

Merged

3 tasks

sigmavirus24 mentioned this issue May 9, 2016

PEP-8 Update on Knuth style breaking of a long formula #504

Closed

larsyencken mentioned this issue May 17, 2016

The preferred place to break around a binary operator is after the operator, not before it #197

Closed

sigmavirus24 added a commit to sigmavirus24/pep8 that referenced this issue May 21, 2016

Add W504 for line breaks before binary operators

4db5041

This flips the W503 rule to enforce line breaks before binary operators. Related PyCQA#498

b4hand mentioned this issue May 27, 2016

W503 enforces breaking after binary operators but PEP-8 appears to disagree #513

Closed

IanLee1521 reopened this May 31, 2016

IanLee1521 changed the title ~~Update handling of breaking around binary operators~~ Update handling of breaking around binary operators: W503 vs W504 May 31, 2016

mauritsvanrees mentioned this issue Jun 21, 2016

Minor cleanup reinout/z3c.dependencychecker#43

Merged

IanLee1521 pushed a commit that referenced this issue Jun 26, 2016

Add W504 for line breaks before binary operators

20a3759

This flips the W503 rule to enforce line breaks before binary operators. Related #498

IanLee1521 pushed a commit that referenced this issue Jun 26, 2016

Add W504 for line breaks before binary operators

c2f607e

This flips the W503 rule to enforce line breaks before binary operators. Related #498

natefoo mentioned this issue Jul 7, 2016

Ignore W503 (line break before binary operator) as PEP 8 has reversed its position on this. galaxyproject/galaxy#2594

Merged

koterpillar mentioned this issue Apr 20, 2018

Avoid line breaks after binary operators aloetesting/aloe_django#60

Merged

toonn mentioned this issue Apr 21, 2018

Pep8 update regarding binary operators ranger/ranger#1145

Closed

yelizariev mentioned this issue Apr 23, 2018

Switch to W504 from W503 (line break before a logical operator) OCA/maintainer-quality-tools#545

Closed

LefterisJP mentioned this issue Apr 24, 2018

Style guide fix for W503 W504 raiden-network/raiden#1382

Merged

StrikerRUS mentioned this issue May 5, 2018

[ci][python] updated pep8 to pycodestyle microsoft/LightGBM#1358

Merged

luisg123v mentioned this issue May 12, 2018

Disable lint W503 (break around binary operators) because doesn't conform PEP-8 OCA/maintainer-quality-tools#552

Closed

asford mentioned this issue Jul 17, 2018

Pycodestyle W503 vs W504 uw-ipd/tmol#89

Closed

asford referenced this issue in uw-ipd/tmol Jul 17, 2018

ugh, yapf kept undoing my linting fixes

f51fd17

yangle added a commit to yangle/dotfiles that referenced this issue Sep 4, 2018

Add W503 to flake8 ignore list

3c5162d

PyCQA/pycodestyle#498

reupen mentioned this issue Oct 24, 2018

Update Flake8 to version 3.6.0 uktrade/data-hub-api#1192

Merged

6 tasks

sampsyo added a commit to beetbox/confuse that referenced this issue Oct 24, 2018

Update whitespace for latest pycodestyle

38669cc

See: PyCQA/pycodestyle#498

aplanas mentioned this issue Oct 25, 2018

Cleanup code to make flake8 happy OSInside/kiwi#861

Merged

micahjsmith added a commit to MLBazaar/BTB that referenced this issue Nov 1, 2018

Ignore line break warnings

ca2888b

We removed all default disabled warnings, but then should add back in W503 and W504 (split after binary operator). See PyCQA/pycodestyle#498

jon-turney mentioned this issue Dec 2, 2018

More clang for Windows support mesonbuild/meson#4573

Merged

simleo mentioned this issue Dec 31, 2018

Fix flake8 errors crs4/pydoop#333

Merged

adler-j mentioned this issue Jan 17, 2019

Geometry for circular detectors odlgroup/odl#1449

Merged

DStape added a commit to DStape/flask-apispec that referenced this issue Feb 11, 2019

Fix failing tox build

13bb08e

Add upper version constraint to apispec and ignore flake8 warning. PyCQA/pycodestyle#498

DStape added a commit to DStape/flask-apispec that referenced this issue Feb 11, 2019

Fix failing tox build

0981819

Add upper version constraint to apispec and ignore flake8 warning. PyCQA/pycodestyle#498

cclauss mentioned this issue Mar 28, 2019

Add Faker hook pyinstaller/pyinstaller#4133

Closed

g1itch mentioned this issue Sep 10, 2019

Code Quality Fixes(3) Bitmessage/PyBitmessage#1518

Merged

drybjed mentioned this issue Jan 17, 2020

Contradictory configuration of flake8 durimg role/collection import ansible/galaxy#2199

Closed

asottile mentioned this issue Apr 3, 2021

W503 shouldn't exist PyCQA/flake8#494

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update handling of breaking around binary operators: W503 vs W504 #498

Update handling of breaking around binary operators: W503 vs W504 #498

IanLee1521 commented Apr 15, 2016

hai-ld commented Apr 20, 2016

methane commented Apr 20, 2016

warsaw commented Apr 20, 2016

sigmavirus24 commented Apr 20, 2016

hai-ld commented Apr 21, 2016

sigmavirus24 commented Apr 21, 2016

hai-ld commented Apr 21, 2016

sigmavirus24 commented Apr 21, 2016

IanLee1521 commented May 31, 2016

Update handling of breaking around binary operators: W503 vs W504 #498

Update handling of breaking around binary operators: W503 vs W504 #498

Comments

IanLee1521 commented Apr 15, 2016

hai-ld commented Apr 20, 2016

methane commented Apr 20, 2016

warsaw commented Apr 20, 2016

sigmavirus24 commented Apr 20, 2016

hai-ld commented Apr 21, 2016

sigmavirus24 commented Apr 21, 2016

hai-ld commented Apr 21, 2016

sigmavirus24 commented Apr 21, 2016

IanLee1521 commented May 31, 2016