This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Release Sentinel v1.3.0 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of pycodestyle (2.4.0) requires a few more rules to be satisfied, one of which is Python raw strings for regexp's (which is a good idea IMO). This commit updates the regular expressions that were previously not using raw strings, to use them.
This commit disables warnings W503 and W504. One of these was added to the default ignore list because it wasn't clear, and line breaks conflict with another rule which doesn't allow lines greater than 80 chars. I believe that disabling these rules (W503 + W504) is the cleaner solution. See also discussion here: PyCQA/pycodestyle#498
This ensures the method still works as expected after the raw string change in comment filter regex.
upgrade pycodestyle due to bug in older version
* removes remaining SHIM_serialise_for_dashd method (not used any longer) * changes serialization format of triggers submitted to the new format, which changed serialized trigger size in a test and uncovered a bug in the size check * fixes a bug in govobj size limit check in superblock creation (use a temp list to check payments, and only add a proposal to the confirmed payments list after size is checked) * calculate reasonable mock gobject size limit in test This removes the hard-coded max size in the test. Due to the proposal serialization format changing, this hard-coded limit won't work now, and the test should be more robust anyway.
submit new simpler format Trigger objects
remove trigger size limit
Also remove specific versions to align w/new versioning strategy.
|
Once merged to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes: