Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyO3 backend #29

Merged
merged 8 commits into from
Jul 4, 2018
Merged

PyO3 backend #29

merged 8 commits into from
Jul 4, 2018

Conversation

termoshtt
Copy link
Collaborator

@termoshtt termoshtt commented May 4, 2018

Resolve #23

  • It is hard to support both PyO3 and rust-cpython interface.
    • rust-numpy 0.2.* uses rust-cpython, and will be deprecated after PyO3 can be compiled with stable Rust Compile with stable rust pyo3#5
    • rust-numpy 0.3 uses PyO3

TODO

  • Replace rust-cpython -> PyO3
  • Adopt to PyO3 interface
  • Fix CI (since PyO3 needs nightly)

@termoshtt
Copy link
Collaborator Author

error[E0277]: the trait bound `numpy::PyArray: pyo3::FromPyObject<'_>` is not satisfied
error[E0277]: the trait bound `numpy::PyArray: pyo3::IntoPyObject` is not satisfied

These should be addressed.

@termoshtt
Copy link
Collaborator Author

Use pyobject_* macros exposed in PyO3/pyo3#155, and revised in my branch

The exposed macro works fine. But PyArray_Type and PyArray_Check are still incompatible with PyO3.

@dthul
Copy link

dthul commented Jun 21, 2018

It would be awesome if this worked. Anything you could use help with?

@kngwyu kngwyu mentioned this pull request Jul 2, 2018
@kngwyu kngwyu merged commit 2e1b069 into master Jul 4, 2018
@kngwyu kngwyu mentioned this pull request Aug 22, 2018
@messense messense deleted the pyo3 branch July 11, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants