Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unravelling of oil bus consistent with new refineries #150

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

nworbmot
Copy link
Member

@nworbmot nworbmot commented Aug 2, 2024

I.e. separate DE oil primary from DE oil. This is a partner to PyPSA-Eur PR https://github.com/PyPSA/pypsa-eur/pull/1192/files.

I.e. separate DE oil primary from DE oil.
@lindnemi
Copy link
Collaborator

lindnemi commented Aug 2, 2024

looks good

the model ran through without problems, but i still want to update the exporter before merging.

open points:

  • should decentral heating oil be considered a Liquid?
  • update how prices are computed in the exporter @JulianGeis

@nworbmot
Copy link
Member Author

nworbmot commented Aug 2, 2024

Decentral heating oil is a liquid.

Copy link
Contributor

@toniseibold toniseibold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We just have to be careful later on when with all those changes in PyPSA-Eur/ariadne2 branch

@lindnemi lindnemi merged commit 8435176 into main Aug 6, 2024
1 check passed
Copy link

github-actions bot commented Aug 6, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

Config
prefix: 240806oilrefineries

Result plots comparison
Base branch Feature branch
primary_energy.png Image not found Image not found
secondary_energy.png Image not found Image not found
final_energy.png Image not found Image not found
Result files comparison
Numeric Status NMAE MAPE
20240731newcutout/KN2045_Bal_v4/csvs/curtailment.csv 72.2% ⚠️Changed 0.09 31.5%
20240731newcutout/KN2045_Bal_v4/csvs/nodal_supply_energy.csv 59.2% ✅ Almost equal 0.00 1.51e+07%
20240731newcutout/KN2045_Bal_v4/csvs/costs.csv 65.1% ✅ Almost equal 0.02 37.9%
20240731newcutout/KN2045_Bal_v4/csvs/nodal_cfs.csv 64.1% ✅ Almost equal 0.02 5.59e+02%
20240731newcutout/KN2045_Bal_v4/csvs/market_values.csv 77.9% ✅ Almost equal 0.03 1.6%
20240731newcutout/KN2045_Bal_v4/csvs/supply_energy.csv 64.7% ✅ Almost equal 0.03 46.7%
20240731newcutout/KN2045_Bal_v4/csvs/cfs.csv 72.3% ✅ Almost equal 0.04 3.3%
20240731newcutout/KN2045_Bal_v4/csvs/cumulative_cost.csv 84.7% ✅ Almost equal 0.09 0.0%
20240731newcutout/KN2045_Bal_v4/csvs/energy.csv 72.9% ✅ Almost equal 0.02 36.9%
20240731newcutout/KN2045_Bal_v4/csvs/prices.csv 81.1% ✅ Almost equal 0.00 1.4%
20240731newcutout/KN2045_Bal_v4/csvs/nodal_costs.csv 58.2% ✅ Almost equal 0.00 3.14e+07%
20240731newcutout/KN2045_Bal_v4/csvs/price_statistics.csv 57.1% ✅ Almost equal 0.08 0.9%
20240731newcutout/KN2045_Bal_v4/csvs/supply.csv 64.7% ✅ Almost equal 0.01 52.2%
20240731newcutout/KN2045_Bal_v4/csvs/nodal_capacities.csv 64.6% ✅ Almost equal 0.00 6.54e+06%
20240731newcutout/KN2045_Bal_v4/csvs/capacities.csv 72.6% ✅ Almost equal 0.01 45.1%
20240731newcutout/KN2045_Bal_v4/csvs/metrics.csv 54.5% ✅ Almost equal 0.05 16.5%
20240731newcutout/KN2045_Bal_v4/csvs/weighted_prices.csv ✅ Equal

MAPE: Mean Absolute Percentage Error
NMAE: Mean Absolute Error on Min-Max Normalized Data
Status Thresholds: NMAE > 0.05 and MAPE > 5%

Comparing refineries (048c46d) with main (8435176).
Branch is 0 commits ahead and 1 commits behind main.
Last updated on 2024-08-06 15:57:07 CEST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants