-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature jg #6
Merged
Merged
Feature jg #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JulianGeis, we can worry about the merge conflicts after you've had a look at the code review. |
removed the clipping and set the default build_year to 2032
The constraint in additional_functionality.py was incredibly unperformant, raising presolving time by 4 hours. Now the restriction is applied before solving with: n.links_t.p_max_pu = p_min_pu = load_profile_pu for new boilers.
Boiler bug: The forced p_min/max_pu profiles for new boilers were being carried forward to future years by add_brownfield.py and interfering with the separate constraint for existing boiler profiles in additional_functionality.py (that allows a profile downscaling). This created infeasibilities. Retrofitting bug: The exogeneous space heating reduction in config.yaml was under "industry" instead of "sector" so not being taken over at all.
fneum
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JulianGeis, have a look at my changes in ef5afa0.
Looks good! I have checked the main mechanisms, and I think this can be merged now.
Here's what I changed:
- I removed some accidental code additions.
- The function
reduce_capacity
is now vectorized. You generally want to avoid iterating over rows of a dataframe with.iterrows()
as this can lead to performance regressions. - The
lossy_bidirectional_links()
function can get a subset to avoid duplicate links in pathway optimisation - some small-ish code simplifications, in particular in the block fixing the capacities for investment years before 2030 :)
- added
mock_snakemake()
- removed most function inceptions, i.e. function definitions inside functions
- added color for Wasserstoffkernnetz for plotting
fneum
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Wasserstoff Kernnetz" is a starting network for hydrogen transport proposed by the Vereinigung der Fernleitungsnetzbetreiber Gas e.V. -> https://fnb-gas.de/wasserstoffnetz-wasserstoff-kernnetz/
It is supposed to be build up until 2032, starting in 2025. To adapt the scenarios on the newly planned infrastructure, this feature implements the kernnetz.
Summary:
Map of the FNB Gas e.V:
Kernnetz after build_kernnetz.py:
Kernnetz with 22 model regions after clustering:
Kernnetz after integration in pypsa-ariadne with currently 22 clusters:
Code used to reproduce the plots: