Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasserstoff kernnetz #871

Merged
merged 6 commits into from
Jan 19, 2024
Merged

wasserstoff kernnetz #871

merged 6 commits into from
Jan 19, 2024

Conversation

JulianGeis
Copy link
Contributor

@JulianGeis JulianGeis commented Jan 17, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Added code to include the wasserstoff kernnetz if it is added as a set of custom h2_pipes. In combination with PR PyPSA/pypsa-ariadne#6 from ariadne repository.

Checklist

  • [ x] I tested my contribution locally and it seems to work fine.
  • [ x] Code and workflow changes are sufficiently documented.
  • [x ] Changed dependencies are added to envs/environment.yaml.

@JulianGeis JulianGeis requested a review from fneum January 17, 2024 10:32
@JulianGeis JulianGeis self-assigned this Jan 17, 2024
@JulianGeis JulianGeis marked this pull request as draft January 17, 2024 11:27
@JulianGeis JulianGeis marked this pull request as ready for review January 18, 2024 10:29
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, with a few minor code-style suggestions.

@JulianGeis, have a look at the changes; then you can commit them via the buttons below. Then, I will merge.

scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
JulianGeis and others added 3 commits January 19, 2024 09:56
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
@fneum fneum merged commit 195966a into master Jan 19, 2024
3 of 5 checks passed
@fneum fneum deleted the feature_kernnetz branch January 19, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants