Small fixes #167
Merged
Small fixes #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lisazeyen
commented
Sep 24, 2021
lisazeyen
commented
- add missing color for H2 liquidation to config.default.yaml
- adjust for myopic optimisation selection of assets to new default lifetime and build year
- remove trailiing whitespace in index of electricity load of pypsa-eur network
fneum
approved these changes
Sep 27, 2021
scripts/prepare_sector_network.py
Outdated
Comment on lines
2010
to
2017
| clusters=48, | ||
| clusters='45', | ||
| lv=1.0, | ||
| opts='', | ||
| sector_opts='Co2L0-168H-T-H-B-I-solar3-dist1', | ||
| planning_horizons=2020, | ||
| planning_horizons='2030', |
There was a problem hiding this comment.
Keeping clusters as int would be nicer. Doesn't that work?
There was a problem hiding this comment.
No, it does not work. It breaks if it is of type int when slicing in the function update_wind_solar_costs
scripts/prepare_sector_network.py
Outdated
| @@ -2007,10 +2010,11 @@ def limit_individual_line_extension(n, maxext): | |||
| snakemake = mock_snakemake( | |||
| 'prepare_sector_network', | |||
| simpl='', | |||
| clusters=48, | |||
| clusters='45', | |||
There was a problem hiding this comment.
Suggested change
| clusters='45', | |
| clusters=45, |
fneum
reviewed
Sep 27, 2021
|
Sorry, made a big mess, squashing this time since it's only a few lines and doesn't contribute to stats. |
leonsn
pushed a commit
to leonsn/pypsa-eur-sec
that referenced
this pull request
Nov 22, 2021
… factor indicated in the config file, eg: solar+c0.5 This is almost a direct copy PyPSA-Eur PyPSA#167 PyPSA/pypsa-eur#167 A factor altering the maximum capacity (p_nom_max) can also be specified by e.g. solar+p3 One should be careful when using this for solar because the factor is applied to all the generators whose carrier includes the string 'solar' (i.e., it is applied to both utility and rooftop solar) I would suggest implementing 'solar utility' and 'solar rooftop' as carriers, since this can be useful for other selecting processes. Is there is any reason for keeping 'solar' as a carrier for 'solar utility'? The previous way of increasing maximum capacity via the config file (e.g 'solar3') is still present in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.