Complete carrier set #653
Complete carrier set #653
Conversation
Note: - battery charger and battery discharger has no nice name nor plot_color - H2 electrolysis is similar to H2 Electrolysis in the tech_color - H2 fuel cell is similar to H2 Fuel cell in the tech_color - H2 pipeline do have have nice name and tech_color, but the addition of it depends on the link being true in config
add_missing_carrier() are applied on python script where new components are added. The function runs ideally after all of the new components are added and before add_nice_carrier_names()
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Great, thanks @virio-andreyana. Did we say we want to add the carrier colors and nice names in this PR as well?
Co-authored-by: Fabian Hofmann <fab.hof@gmx.de>
we can:
The third choice looks cleaner, I.ll do that |
…issing_carrier_with_nice_names(n, config)
for more information, see https://pre-commit.ci
|
Hey @virio-andreyana little things remaining: WARNING:add_electricity:tech_colors for carriers ['DC', 'H2 electrolysis', 'H2 fuel cell'] not defined in config. and could you add a release note? |
@FabianHofmann, in the release_notes.rst should I put the changes in PyPSA-Eur 0.8.0 (18th March 2023) or in a newer version? |
in "Upcoming Release" https://github.com/PyPSA/pypsa-eur/blob/master/doc/release_notes.rst |
for more information, see https://pre-commit.ci
|
great thanks @virio-andreyana |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Closes #633
Changes proposed in this Pull Request
add the function add_missing_carrier in add_electricity in order to ensure complete set of carriers mentioned in issue #633 . The function is copied in
Checklist
doc/configtables/*.csv.doc/release_notes.rstis added.