Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select correct sector name in endogeneous retrofitting #808

Merged
merged 27 commits into from
Jan 5, 2024
Merged

Conversation

martacki
Copy link
Member

@martacki martacki commented Dec 20, 2023

Changes proposed in this Pull Request

Turns out we're making this PR bigger and include many more fixes than originally intended:

  • selection of the sector sec never chose services, thus costs of retrofitting services were highly overestimated (on average by a factor of 4). Fixed by correctly defining the corresponding variable sec
  • introduced a more general node name that allows more than 9 buses per synchronous region
  • avoiding deprecation of .groupby(axis=1) and not using .loc[]
  • discriminate between district heating, decentral heating in urban areas or rural areas for floor_area_node calculations
  • discriminate between gas boilers and resistive heaters in configuration (config.default.yaml), default settings align with previous settings
  • remove gas generators in sector network if gas is a carrier (only gas store allowed)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@martacki martacki marked this pull request as draft December 20, 2023 19:25
@martacki martacki marked this pull request as ready for review December 21, 2023 10:13
@martacki martacki marked this pull request as draft December 21, 2023 13:26
@martacki martacki marked this pull request as ready for review January 4, 2024 14:03
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes look good. Thanks @martacki.

I am just unsure about skipping the gas generator. Wouldn't that mean the model can't use fossil gas anymore?

scripts/prepare_sector_network.py Show resolved Hide resolved
Comment on lines +500 to +501
if carrier == "gas":
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if carrier == "gas":
return

This would prohibit the use of fossil gas, wouldn't it?

Since the store is cyclic, where would the model source fossil gas?

@fneum fneum merged commit 817995c into master Jan 5, 2024
5 checks passed
@fneum fneum deleted the services_heat branch January 5, 2024 13:39
@fneum
Copy link
Member

fneum commented Jan 5, 2024

I merged without removing the gas generators. Feel free to amend in another PR if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants