-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
select correct sector name in endogeneous retrofitting #808
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
fix f weighting for retro cost
for more information, see https://pre-commit.ci
Resolve waste heat and resistive heaters (issue1 and issue2)
No gas generators
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most changes look good. Thanks @martacki.
I am just unsure about skipping the gas generator. Wouldn't that mean the model can't use fossil gas anymore?
if carrier == "gas": | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if carrier == "gas": | |
return |
This would prohibit the use of fossil gas, wouldn't it?
Since the store is cyclic, where would the model source fossil gas?
I merged without removing the gas generators. Feel free to amend in another PR if necessary. |
Changes proposed in this Pull Request
Turns out we're making this PR bigger and include many more fixes than originally intended:
sec
never choseservices
, thus costs of retrofitting services were highly overestimated (on average by a factor of 4). Fixed by correctly defining the corresponding variablesec
.groupby(axis=1)
and not using.loc[]
floor_area_node
calculationsChecklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.