Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect complex reduction in real builds. #4379

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Protect complex reduction in real builds. #4379

merged 2 commits into from
Jan 4, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 4, 2023

Proposed changes

Getting llvm-link error in real builds with icpx due to unprotected reduction on complex in offload regions.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

sunspot

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 4, 2023

Test this please

prckent
prckent approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. Since we will likely gain more of these workarounds, how about adding // COMPILER WORKAROUND or similar so that we can find these in future?

@prckent
Copy link
Contributor

prckent commented Jan 4, 2023

Test this please

@ye-luo ye-luo merged commit 0e75f5c into QMCPACK:develop Jan 4, 2023
@ye-luo ye-luo deleted the fix-icpx branch January 4, 2023 16:41
@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 4, 2023

Q. Since we will likely gain more of these workarounds, how about adding // COMPILER WORKAROUND or similar so that we can find these in future?

Added on #4380 which needs a new approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent