Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sycl include #4380

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Update sycl include #4380

merged 4 commits into from
Jan 4, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 4, 2023 •
edited
Loading

Proposed changes

Kill a few warning when using sycl

  1. --dpcpp option is gone
  2. sycl header file changed namespace by replacing CL with sycl. CL namespace is deprecated.

What type(s) of changes does this code introduce?

  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

sunspot

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

prckent
prckent previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent
Copy link
Contributor

prckent commented Jan 4, 2023

Test this please

@prckent prckent enabled auto-merge January 4, 2023 14:00
@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 4, 2023

Test this please

@ye-luo ye-luo mentioned this pull request Jan 4, 2023
Merged
prckent
prckent approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent prckent merged commit 1dd8a38 into QMCPACK:develop Jan 4, 2023
@ye-luo ye-luo deleted the update-sycl-include branch January 4, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent