Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix unit test CI #572

Closed
mickahell opened this issue Nov 6, 2023 · 0 comments · Fixed by #586
Closed

[CI] Fix unit test CI #572

mickahell opened this issue Nov 6, 2023 · 0 comments · Fixed by #586
Labels
bug Something isn't working

Comments

@mickahell
Copy link
Collaborator

Steps to reproduce the problem

Run the sourcecode test CI.

What is the current behavior?

An update of qiskit package make broke the unittest : test_tests_runner_on_simple_repo

What is the expected behavior?

This test should pass.

@mickahell mickahell added the bug Something isn't working label Nov 6, 2023
frankharkins pushed a commit that referenced this issue Nov 13, 2023
<!--
⚠️ If you do not respect this template, your pull request will be
closed.
⚠️ Your pull request title should be short detailed and understandable
for all.
⚠️ Also, please add a release note file using reno if the change needs
to be
  documented in the release notes.
⚠️ If your pull request fixes an open issue, please link to the issue.

- [ ] I have added the tests to cover my changes.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
-->

### Summary

The test depreciation test can't be used right now until the new version
of qiskit isn't largely used. It come from we still used the old way to
check the qiskit version of projects in order to not get the terra
version. It will be able to revert this change when qiskit terra gonna
totally disappeared.

Cause :

https://github.com/Qiskit/ecosystem/blob/0212a863ffdc1ece3964285ac295db6565500332/ecosystem/templates/configured_tox.ini#L32
As we want to keep the qiskit version and not the terra version we have
to keep it this way for now.


### Details and comments
- [x] Update test `test_tests_runner_on_simple_repo`
- [x] Add test `test_website_builder`

---
Closes #572

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant