Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Desactived depreciation test & add test for website builder #586

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

mickahell
Copy link
Collaborator

@mickahell mickahell commented Nov 11, 2023

Summary

The test depreciation test can't be used right now until the new version of qiskit isn't largely used. It come from we still used the old way to check the qiskit version of projects in order to not get the terra version. It will be able to revert this change when qiskit terra gonna totally disappeared.

Cause :

python -c 'import qiskit; f = open("./qiskit_version.txt", "w"); f.write(qiskit.__qiskit_version__["qiskit"]); f.close();'

As we want to keep the qiskit version and not the terra version we have to keep it this way for now.

Details and comments

  • Update test test_tests_runner_on_simple_repo
  • Add test test_website_builder

Closes #572

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2023

CLA assistant check
All committers have signed the CLA.

@mickahell mickahell self-assigned this Nov 11, 2023
@mickahell mickahell changed the title [BUG] Change test true [BUG] Desactived depreciation test & add test for website builder Nov 11, 2023
@mickahell
Copy link
Collaborator Author

@frankharkins ready for your review :)

tests/runners/test_runner.py Outdated Show resolved Hide resolved
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@frankharkins frankharkins merged commit 0dd2946 into Qiskit:main Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Fix unit test CI
4 participants