Parse array types in the AST #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support already existed in the lexer. * Basic support for parsing in oq3_parser. Everything was set up for this. So it was easy. Array types may occur in places not covered by this implementation. * The only consumer to date is Qiskit. Arrays are not currently a priority for Qiskit. So in the AST -> ASG translation, we throw a not-supported error if an array type is found. However, supporting array types in AST -> ASG is straightforward and should take little time. * Some clarifying comments in unrelated functions were added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support already existed in the lexer.
Basic support for parsing in oq3_parser. Everything was set up for this. So it was easy. Array types may occur in places not covered by this implementation.
The only consumer to date is Qiskit. Arrays are not currently a priority for Qiskit. So in the AST -> ASG translation, we throw a not-supported error if an array type is found. However, supporting array types in AST -> ASG is straightforward and should take little time.
Some clarifying comments in unrelated functions were added.
Comments