Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse array types in the AST #156

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Parse array types in the AST #156

merged 1 commit into from
Feb 26, 2024

Commits on Feb 26, 2024

  1. Parse array types in the AST 

    * Support already existed in the lexer.
* Basic support for parsing in oq3_parser. Everything was set up for this.
  So it was easy. Array types may occur in places not covered by this implementation.
* The only consumer to date is Qiskit. Arrays are not currently a priority for Qiskit. So in the
  AST -> ASG translation, we throw a not-supported error if an array type is found. However,
  supporting array types in AST -> ASG is straightforward and should take little time.

* Some clarifying comments in unrelated functions were added.
    @jlapeyre
    jlapeyre committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a50e50e View commit details
    Browse the repository at this point in the history