Skip to content

Commit

Permalink
Fix issue with wheel automation from first attempt (#589)
Browse files Browse the repository at this point in the history
We recently pushed out the 0.4.0 release which was our first attempt of
using the wheel automation in production. There were a few issues
identified by the process, first several jobs forgot to add twine to the
install. This was not caught because we never tested the actual wheel
upload during the dry runs. Then for the sdist job we needed to update
the version of pip used in the job to actually be able to install some
of aer's build dependencies. The last oversight was that we never added
the additional trigger for tags to trigger the wheel jobs on azure
pipelines. This meant at release time the jobs never got triggered or
ran. This commit fixes all these issues so for the next release the
process should all work correctly.
  • Loading branch information
mtreinish authored Feb 6, 2020
1 parent 474fef4 commit 83b2c72
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
5 changes: 3 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ jobs:
- CIBW_TEST_REQUIRES="git+https://github.com/Qiskit/qiskit-terra.git"
if: tag IS present
script:
- pip install -U pip virtualenv
- pip install -U pip virtualenv twine
- pip install cibuildwheel==1.1.0
- cibuildwheel --output-dir wheelhouse
- twine upload wheelhouse/*
Expand All @@ -280,7 +280,8 @@ jobs:
env:
- TWINE_USERNAME=qiskit
python: 3.7
before_script: true
before_script:
- pip install -U pip setuptools virtualenv twine
install: true
script:
- python setup.py sdist
Expand Down
10 changes: 8 additions & 2 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,13 @@
# https://docs.microsoft.com/azure/devops/pipelines/languages/python

trigger:
- master
- stable
branches:
include:
- master
- stable/*
tags:
include:
- '*'

stages:
- stage: 'Wheel_Builds'
Expand Down Expand Up @@ -55,6 +60,7 @@ stages:
inputs: {pathtoPublish: 'wheelhouse'}
condition: succeededOrFailed()
- bash: |
pip install -U twine
twine upload wheelhouse/*
env:
TWINE_PASSWORD: $(TWINE_PASSWORD)
Expand Down

0 comments on commit 83b2c72

Please sign in to comment.