Fix issue with wheel automation from first attempt #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently pushed out the 0.4.0 release which was our first attempt of using the wheel automation in production. There were a few issues identified by the process, first several jobs forgot to add twine to the install. This was not caught because we never tested the actual wheel upload during the dry runs. Then for the sdist job we needed to update the version of pip used in the job to actually be able to install some of aer's build dependencies. The last oversight was that we never added the additional trigger for tags to trigger the wheel jobs on azure pipelines. This meant at release time the jobs never got triggered or ran. This commit fixes all these issues so for the next release the process should all work correctly.
mtreinish
added
the
stable-backport-potential
atilag
approved these changes
Feb 6, 2020
mtreinish
added a commit
to mtreinish/qiskit-aer
that referenced
this pull request
Feb 6, 2020
We recently pushed out the 0.4.0 release which was our first attempt of using the wheel automation in production. There were a few issues identified by the process, first several jobs forgot to add twine to the install. This was not caught because we never tested the actual wheel upload during the dry runs. Then for the sdist job we needed to update the version of pip used in the job to actually be able to install some of aer's build dependencies. The last oversight was that we never added the additional trigger for tags to trigger the wheel jobs on azure pipelines. This meant at release time the jobs never got triggered or ran. This commit fixes all these issues so for the next release the process should all work correctly. (cherry picked from commit 83b2c72)
atilag
pushed a commit
that referenced
this pull request
Feb 6, 2020
We recently pushed out the 0.4.0 release which was our first attempt of using the wheel automation in production. There were a few issues identified by the process, first several jobs forgot to add twine to the install. This was not caught because we never tested the actual wheel upload during the dry runs. Then for the sdist job we needed to update the version of pip used in the job to actually be able to install some of aer's build dependencies. The last oversight was that we never added the additional trigger for tags to trigger the wheel jobs on azure pipelines. This meant at release time the jobs never got triggered or ran. This commit fixes all these issues so for the next release the process should all work correctly. (cherry picked from commit 83b2c72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We recently pushed out the 0.4.0 release which was our first attempt of
using the wheel automation in production. There were a few issues
identified by the process, first several jobs forgot to add twine to the
install. This was not caught because we never tested the actual wheel
upload during the dry runs. Then for the sdist job we needed to update
the version of pip used in the job to actually be able to install some
of aer's build dependencies. The last oversight was that we never added
the additional trigger for tags to trigger the wheel jobs on azure
pipelines. This meant at release time the jobs never got triggered or
ran. This commit fixes all these issues so for the next release the
process should all work correctly.
Details and comments