Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cu1 fusion #334

Merged
merged 2 commits into from
Sep 6, 2019
Merged

support cu1 fusion #334

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89a3bc
support cu1 fusion
hhorii Aug 31, 2019
f3c075e
simplify a logic to identify an unrolled cu1
hhorii Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions src/transpile/fusion.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
#ifndef _aer_transpile_fusion_hpp_
#define _aer_transpile_fusion_hpp_

//#define DEBUG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have unintentionally left this commented line I guess.. :)


#include "transpile/circuitopt.hpp"

namespace AER {
Expand Down Expand Up @@ -116,6 +118,7 @@ const std::vector<std::string> Fusion::supported_gates({
// Two-qubit gates
"CX", // Controlled-X gate (CNOT)
"cx", // Controlled-X gate (CNOT)
"cu1", // Controlled-U1 gate
"cz", // Controlled-Z gate
"swap" // SWAP gate
// Three-qubit gates
Expand Down Expand Up @@ -514,21 +517,21 @@ bool Fusion::only_u1(const std::vector<op_t>& ops,
const uint_t until) const {

for (uint_t i = from; i <= until; ++i) {
if (ops[i].name == "u1")
continue;
if (from < i && (i + 2) <= until
&& ops[i - 1].name == "u1"
&& ops[i ].name == "cx"
&& ops[i + 1].name == "u1"
&& ops[i + 2].name == "cx"
&& ops[i - 1].qubits[0] == ops[i ].qubits[1]
&& ops[i ].qubits[1] == ops[i + 1].qubits[0]
&& ops[i + 1].qubits[0] == ops[i + 2].qubits[1]
&& ops[i ].qubits[0] == ops[i + 2].qubits[0] )
if ((i + 3) <= until
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great if we can add a comment in this method to explain what is trying to do, something like:

// This method will seek for this pattern of gates in the circuit:
// ---[u1]---|---[u1]---|---
// --------[cx]-------[cx]--
// And optimize it by blablabla...

&& ops[i ].name == "u1"
&& ops[i + 1].name == "cx"
&& ops[i + 2].name == "u1"
&& ops[i + 3].name == "cx"
&& ops[i ].qubits[0] == ops[i + 1].qubits[1]
&& ops[i + 1].qubits[1] == ops[i + 2].qubits[0]
&& ops[i + 2].qubits[0] == ops[i + 3].qubits[1]
&& ops[i + 1].qubits[0] == ops[i + 3].qubits[0] )
{
i += 2;
i += 3;
continue;
}
if (ops[i].name == "u1" || ops[i].name == "cu1")
continue;
return false;
}
return true;
Expand Down Expand Up @@ -579,6 +582,13 @@ cmatrix_t Fusion::matrix(const op_t& op) const {
{ {1, 0}, {0, 0} },
{ {0, 0}, std::exp( complex_t(0, 1.) * std::real(op.params[0])) }}
);
} else if (op.name == "cu1") { // zero-X90 pulse waltz gate
return Utils::make_matrix<complex_t>( {
{ {1, 0}, {0, 0}, {0, 0}, {0, 0} },
{ {0, 0}, {1, 0}, {0, 0}, {0, 0} },
{ {0, 0}, {0, 0}, {1, 0}, {0, 0} },
{ {0, 0}, {0, 0}, {0, 0}, std::exp( complex_t(0, 1.) * std::real(op.params[0])) }}
);
} else if (op.name == "u2") { // single-X90 pulse waltz gate
return Utils::Matrix::u3( M_PI / 2., std::real(op.params[0]), std::real(op.params[1]));
} else if (op.name == "u3" || op.name == "U") { // two X90 pulse waltz gate
Expand Down