Skip to content

Commit

Permalink
Add vim to images (#1186)
Browse files Browse the repository at this point in the history
* add vim to images

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>

We've found that having vim available on images is useful when needing
to debug. So this PR adds it to the ray-node, gateway, and repository images.

* drop vim from ray node

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>

This adds a bit of size, and we run a LOT of ray nodes. The ray image
also allows for `sudo apt install vim`, so we don't need to preinstall
it.
  • Loading branch information
psschwei authored Jan 24, 2024
1 parent dd36305 commit fa916ca
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Dockerfile-ray-node
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN pip install . --no-cache-dir &&\
pip install --no-cache-dir pyarrow==14.0.1 &&\
pip install --no-cache-dir certifi==2023.7.22

WORKDIR /
WORKDIR /
RUN rm -r ./qs

FROM rayproject/ray:2.9.0-$IMAGE_PY_VERSION-aarch64 AS ray-node-arm64
Expand All @@ -24,9 +24,9 @@ WORKDIR /
USER 0
RUN mkdir /data && chown "$RAY_UID":"$RAY_UID" /data
USER $RAY_UID
RUN apt-get -y update &&\
apt-get install --no-install-recommends -y \
gcc=4:9.3.0-1ubuntu2 \
RUN apt-get -y update &&\
apt-get install --no-install-recommends -y \
gcc=4:9.3.0-1ubuntu2 \
build-essential=12.8ubuntu1
COPY --chown=$RAY_UID:$RAY_UID ./client ./qs

Expand Down
2 changes: 1 addition & 1 deletion gateway/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ENV PYTHONUNBUFFERED 1

# install psycopg2 dependencies
RUN apt-get -y update &&\
apt-get install --no-install-recommends -y gcc=4:8.3.0-1 python3-dev=3.7.3-1 &&\
apt-get install --no-install-recommends -y gcc=4:8.3.0-1 python3-dev=3.7.3-1 vim &&\
apt-get clean &&\
rm -rf /var/lib/apt/lists/*

Expand Down
1 change: 1 addition & 0 deletions repository/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ ENV PYTHONDONTWRITEBYTECODE 1
ENV PYTHONUNBUFFERED 1

USER 0
RUN apt-get update && apt-get install -y vim
COPY repository .
RUN chown -R 1001:0 /usr/src/app &&\
pip install -r requirements.txt --no-cache-dir
Expand Down

0 comments on commit fa916ca

Please sign in to comment.