Add vim to images #1186
Merged
Add vim to images #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> We've found that having vim available on images is useful when needing to debug. So this PR adds it to the ray-node, gateway, and repository images.
akihikokuroda
approved these changes
Jan 23, 2024
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> This adds a bit of size, and we run a LOT of ray nodes. The ray image also allows for `sudo apt install vim`, so we don't need to preinstall it.
|
Good call @akihikokuroda . Adding vim adds ~60MB to the image size, and we run a lot of Ray nodes (plus they're ephemeral, unlike the gateway/scheduler). Let's drop vim from the ray node image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul S. Schweigert paul@paulschweigert.com
We've found that having vim available on images is useful when needing to debug. So this PR adds it to the ray-node, gateway, and repository images.