Apply new deprecation decorators to dagcircuit folder (#9874)

* Apply new deprecation decorators to assembler, compiler, and dagcircuit folders

* Fix quantum_instance.py triggering deprecation for max_credits

* Review feedback

* Fmt - oops

qiskit/dagcircuit/dagcircuit.py

@@ -38,7 +38,7 @@
 from qiskit.circuit.parameterexpression import ParameterExpression
 from qiskit.dagcircuit.exceptions import DAGCircuitError
 from qiskit.dagcircuit.dagnode import DAGNode, DAGOpNode, DAGInNode, DAGOutNode
-from qiskit.utils.deprecation import deprecate_function
+from qiskit.utils.deprecation import deprecate_func
 
 
 class DAGCircuit:
@@ -526,10 +526,8 @@ def _add_op_node(self, op, qargs, cargs):
         self._increment_op(op)
         return node_index
 
-    @deprecate_function(
-        "The DAGCircuit._copy_circuit_metadata method is deprecated as of 0.20.0. It will be "
-        "removed no earlier than 3 months after the release date. You should use the "
-        "DAGCircuit.copy_empty_like method instead, which acts identically.",
+    @deprecate_func(
+        additional_msg="Instead, use :meth:`~copy_empty_like()`, which acts identically.",
         since="0.20.0",
     )
     def _copy_circuit_metadata(self):

qiskit/dagcircuit/dagnode.py

@@ -73,7 +73,6 @@ def semantic_eq(node1, node2, bit_indices1=None, bit_indices2=None):
                 "release will require the mappings to be provided as arguments.",
                 DeprecationWarning,
             )
-
             bit_indices1 = {arg: arg for arg in node1.qargs + node1.cargs}
             bit_indices2 = {arg: arg for arg in node2.qargs + node2.cargs}