Apply new deprecation decorators to dagcircuit folder #9874
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4863815032
💛 - Coveralls |
1ucian0
added
the
type: qa
mtreinish
added
the
stable backport potential
…ply-deprecations-assembler
| @@ -73,7 +73,6 @@ def semantic_eq(node1, node2, bit_indices1=None, bit_indices2=None): | |||
| "release will require the mappings to be provided as arguments.", | |||
| DeprecationWarning, | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Oops, didn't mean to do this. Doesn't seem worth a CI burn though - this code path will be deleted soon (deprecation is from 0.20)
Eric-Arellano
changed the title
| "removed no earlier than 3 months after the release date. You should use the " | ||
| "DAGCircuit.copy_empty_like method instead, which acts identically.", | ||
| @deprecate_func( | ||
| additional_msg="Instead, use :meth:`~copy_empty_like()`, which acts identically.", |
There was a problem hiding this comment.
Does it work with ()?
| additional_msg="Instead, use :meth:`~copy_empty_like()`, which acts identically.", | |
| additional_msg="Instead, use :meth:`~copy_empty_like`, which acts identically.", |
There was a problem hiding this comment.
https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#role-py-func
The role text needs not include trailing parentheses to enhance readability; they will be added automatically by Sphinx if the add_function_parentheses config value is True (the default).
* Apply new deprecation decorators to assembler, compiler, and dagcircuit folders * Fix quantum_instance.py triggering deprecation for max_credits * Review feedback * Fmt - oops (cherry picked from commit 94eea5c)
* Apply new deprecation decorators to assembler, compiler, and dagcircuit folders * Fix quantum_instance.py triggering deprecation for max_credits * Review feedback * Fmt - oops (cherry picked from commit 94eea5c) Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
* Apply new deprecation decorators to assembler, compiler, and dagcircuit folders * Fix quantum_instance.py triggering deprecation for max_credits * Review feedback * Fmt - oops
Summary
See #9676 for the motivation.
Details and comments