Remove concurrency handling from Makefile stestr usage #10097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#1973 the Makefile was updated to add manual concurrency handling to the invocation of stestr. At the time (> 4 yrs ag) our CI setup looked very different, everything was run in TravisCI which had much smaller memory quotas in the worker VMs and we also were actively using the Makefile to run tests. Since that time though CI and our development workflow have changed. At the time running multiple tests in parallel was causing us to exhaust the available RAM in the CI workers for MacOS and Windows so we set concurrency limits to prevent this. However, we no longer use travis, and the use of the makefile has long since been replaced by using tox as it provides a unified interface that manges venvs along with running tests in a consistent way across systems (including locally and CI). This commit reverts that change and lets stestr run with it's default concurrency when people use the Makefile. While the Makefile isn't widely used and has been largely superseded by tox, there are still some people using it and of those using MacOS or Windows this should improve local test throughput.
mtreinish
added
type: qa
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4938541775
💛 - Coveralls |
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
In Qiskit#1973 the Makefile was updated to add manual concurrency handling to the invocation of stestr. At the time (> 4 yrs ag) our CI setup looked very different, everything was run in TravisCI which had much smaller memory quotas in the worker VMs and we also were actively using the Makefile to run tests. Since that time though CI and our development workflow have changed. At the time running multiple tests in parallel was causing us to exhaust the available RAM in the CI workers for MacOS and Windows so we set concurrency limits to prevent this. However, we no longer use travis, and the use of the makefile has long since been replaced by using tox as it provides a unified interface that manges venvs along with running tests in a consistent way across systems (including locally and CI). This commit reverts that change and lets stestr run with it's default concurrency when people use the Makefile. While the Makefile isn't widely used and has been largely superseded by tox, there are still some people using it and of those using MacOS or Windows this should improve local test throughput.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #1973 the Makefile was updated to add manual concurrency handling to the invocation of stestr. At the time (> 4 yrs ag) our CI setup looked very different, everything was run in TravisCI which had much smaller memory quotas in the worker VMs and we also were actively using the Makefile to run tests. Since that time though CI and our development workflow have changed. At the time running multiple tests in parallel was causing us to exhaust the available RAM in the CI workers for MacOS and Windows so we set concurrency limits to prevent this. However, we no longer use travis, and the use of the makefile has long since been replaced by using tox as it provides a unified interface that manges venvs along with running tests in a consistent way across systems (including locally and CI). This commit reverts that change and lets stestr run with it's default concurrency when people use the Makefile. While the Makefile isn't widely used and has been largely superseded by tox, there are still some people using it and of those using MacOS or Windows this should improve local test throughput.
Details and comments