Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concurrency handling from Makefile stestr usage #10097

Merged
merged 1 commit into from
May 10, 2023

Commits on May 10, 2023

  1. Remove concurrency handling from Makefile stestr usage

    In Qiskit#1973 the Makefile was updated to add manual concurrency handling to
    the invocation of stestr. At the time (> 4 yrs ag) our CI setup looked
    very different, everything was run in TravisCI which had much smaller
    memory quotas in the worker VMs and we also were actively using the
    Makefile to run tests. Since that time though CI and our development
    workflow have changed. At the time running multiple tests in parallel
    was causing us to exhaust the available RAM in the CI workers for MacOS
    and Windows so we set concurrency limits to prevent this. However, we no
    longer use travis, and the use of the makefile has long since been replaced
    by using tox as it provides a unified interface that manges venvs along
    with running tests in a consistent way across systems (including locally
    and CI). This commit reverts that change and lets stestr run with it's
    default concurrency when people use the Makefile. While the Makefile isn't
    widely used and has been largely superseded by tox, there are still some
    people using it and of those using MacOS or Windows this should improve
    local test throughput.
    mtreinish committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4fa1cdb View commit details
    Browse the repository at this point in the history